Re: [RFC qemu-server 2/4] remote migrate: collect preconditions as structured findings

[Erik Fastermann <e.fastermann@proxmox.com>]

[snip]

>> User-visible effect is minimal: successful migrations are unchanged.
>> Some precondition error messages are reworded and the "Establishing
>> API connection" info line is no longer printed.
> 
> Do we gain anything from not printing it? Such changes can also be nicer
> in separate patches to ease reviewability and discussion.
> 

I thought printing the info line would be noise in the precondition 
endpoint, which I can put in the commit message, in a separate patch.

[snip]
>> +        my $findings = [];
>> +        my $plan = validate_remote_migrate_preconditions($param, $findings);
> 
> Style nit: why pass in $findings like this? You can just return multiple
> values instead. I'd prefer a name like $migration_info rather than $plan.
> 

I didn't want to return the findings array on every possible exit point 
of the function, so I thought this would be nicer. I could add an extra 
wrapper function which does this though, so I will try that.

[snip]