all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Erik Fastermann <e.fastermann@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [RFC qemu-server 4/4] remote migrate: add precondition check endpoint
Date: Fri, 31 Jul 2026 15:43:06 +0200	[thread overview]
Message-ID: <45579630-54b9-4f3d-81e3-efa9e67a59b2@proxmox.com> (raw)
In-Reply-To: <ee9e1846-ee64-46f5-a43a-dca8caa02f26@proxmox.com>

> Am 21.07.26 um 1:58 PM schrieb Erik Fastermann:
>> +                storage => get_standard_option(
>> +                    'pve-storage-id',
>> +                    {
>> +                        description => "Optional associated storage.",
>> +                        optional => 1,
>> +                    },
>> +                ),
> 
> Is the idea to include the storage ID to represent such findings
> differently from other warnings/errors in the UI?

The field is meant as an extension of the code field for machine 
consumers, so a caller can tell which object a finding refers to without 
parsing the message. The UI will most likely need it: The message we 
return cannot always be translated AFAIK, so the UI has to build its own 
string from the code and needs the storage ID separately to fill it in.

Storage is currently the only such field, because it is the only one the 
existing checks need. Further fields can be added the same way as more 
checks arrive.





  reply	other threads:[~2026-07-31 13:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 11:58 [RFC qemu-server 0/4] remote migrate: extract preconditions and add check endpoint Erik Fastermann
2026-07-21 11:58 ` [RFC qemu-server 1/4] remote migrate: drop ineffective fingerprint auto-detection Erik Fastermann
2026-07-29  9:56   ` Fiona Ebner
2026-07-29  9:59     ` Fiona Ebner
2026-07-29 10:02       ` Fiona Ebner
2026-07-29 10:07     ` Fabian Grünbichler
2026-07-29 10:17       ` Fiona Ebner
2026-07-21 11:58 ` [RFC qemu-server 2/4] remote migrate: collect preconditions as structured findings Erik Fastermann
2026-07-29  9:56   ` Fiona Ebner
2026-07-31 13:42     ` Erik Fastermann
2026-07-21 11:58 ` [RFC qemu-server 3/4] qm: remote-migrate: call API endpoint directly Erik Fastermann
2026-07-21 11:58 ` [RFC qemu-server 4/4] remote migrate: add precondition check endpoint Erik Fastermann
2026-07-29  9:56   ` Fiona Ebner
2026-07-31 13:43     ` Erik Fastermann [this message]
2026-07-29  9:56 ` [RFC qemu-server 0/4] remote migrate: extract preconditions and add " Fiona Ebner
2026-07-31 13:42   ` Erik Fastermann
2026-07-31 14:44     ` Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45579630-54b9-4f3d-81e3-efa9e67a59b2@proxmox.com \
    --to=e.fastermann@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal