From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F21701FF0ED for ; Fri, 31 Jul 2026 15:42:56 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9E21A21539; Fri, 31 Jul 2026 15:42:56 +0200 (CEST) Message-ID: <63311ffa-f824-4322-9360-a456e4e51401@proxmox.com> Date: Fri, 31 Jul 2026 15:42:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [RFC qemu-server 2/4] remote migrate: collect preconditions as structured findings To: Fiona Ebner , pve-devel@lists.proxmox.com References: <20260721115827.163442-1-e.fastermann@proxmox.com> <20260721115827.163442-3-e.fastermann@proxmox.com> <26a8a6f4-0870-4bfc-807e-b75275f6d743@proxmox.com> Content-Language: en-US From: Erik Fastermann In-Reply-To: <26a8a6f4-0870-4bfc-807e-b75275f6d743@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785505361804 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.965 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CEZ5HCA5VHUBHGZAVA5NN7A3KDHS7US6 X-Message-ID-Hash: CEZ5HCA5VHUBHGZAVA5NN7A3KDHS7US6 X-MailFrom: e.fastermann@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: [snip] >> User-visible effect is minimal: successful migrations are unchanged. >> Some precondition error messages are reworded and the "Establishing >> API connection" info line is no longer printed. > > Do we gain anything from not printing it? Such changes can also be nicer > in separate patches to ease reviewability and discussion. > I thought printing the info line would be noise in the precondition endpoint, which I can put in the commit message, in a separate patch. [snip] >> + my $findings = []; >> + my $plan = validate_remote_migrate_preconditions($param, $findings); > > Style nit: why pass in $findings like this? You can just return multiple > values instead. I'd prefer a name like $migration_info rather than $plan. > I didn't want to return the findings array on every possible exit point of the function, so I thought this would be nicer. I could add an extra wrapper function which does this though, so I will try that. [snip]