Re: [PATCH cluster/manager v4 0/2] Configurable window titles for nodes

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Mon, Sep 14, 2026 at 08:22:00AM +0200, Thomas Ellmenreich wrote:
> Thank you @Dominik Csapak, @Thomas Lamprecht, @Elias Huhsovitz for your comments.
> 
> Configurable window titles for nodes
> ====================================
> 
> Currently the window title is fixed to the following string:
> 
> $nodename - Proxmox Virtual Environment
> 
> This has become problematic for users with multiple clusters, each containing
> the same node name. To help distinguish between tabs, it has been requested [1]
> that the window title be made configurable with the fqdn as an option.
> 
> [1] https://bugzilla.proxmox.com/show_bug.cgi?id=5475
> 
> Implementation
> --------------
> 
> After considering the different options, I have deemed a server side
> implementation, through the datacenter.cfg, to be the better option.
> Specifically because of its durability across sessions and because it
> automatically configures the title for all users and all nodes across the
> cluster.
> 
> The config now contains a new ui-settings format string which then in turn
> contains a 'title' enum field for the window title. This enum string will then
> be converted to a window title and inserted in the index.html.tpl template on
> every request.
> 
> The current enum options are:
> 
> - default - Displays the default '$nodename - Proxmox Virtual Environment' string
>   if the config enum is not present
> 
> - 'node-and-cluster' - Displays the nodename and then the clustername in the
>   following style: '$nodename - $clustername - Proxmox Virtual Environment'
> 
> - 'fqdn' - Displays the current fqdn as returned by `PVE::Tools::get_fqdn()`
>   like so: '$fqdn - Proxmox Virtual Environment'
> 
> [...]
thanks for the patches! tested node-and-cluster on a cluster and a
standalone node, and fqdn; works as advertised. made a few comments to
the pve-manager patch. I think the missing gettext calls and the window
title fallback should be fixed in the next version, the rest are nits
and one question. 

one other nit: since the pve-manager patch depends on the pve-cluster
one, it would make more sense to put the pve-cluster patch first in the
series.