From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Cc: pve-devel@lists.proxmox.com, Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: Re: [PATCH cluster v4 2/2] fix #5475: configurable window title
Date: Wed, 16 Sep 2026 16:52:09 +0200 [thread overview]
Message-ID: <bz6atezurafzoiwp34m2x2k75ryr2pahoiblcqbor33banzppn@i2bmn3kdqrmn> (raw)
In-Reply-To: <20260914062202.27182-3-t.ellmenreich@proxmox.com>
On Mon, Sep 14, 2026 at 08:22:02AM +0200, Thomas Ellmenreich wrote:
> Added a new 'ui-settings' format string to the datacenter.cfg. Currently
> only contains a 'title' option to determine the window title of the
> nodes browser tab.
>
> Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
> Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
> src/PVE/DataCenterConfig.pm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 004122e..751d8ed 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -344,6 +344,16 @@ my $user_tag_privs_format = {
> },
> };
>
> [...]
lgtm!
Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
next prev parent reply other threads:[~2026-09-16 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 6:22 [PATCH cluster/manager v4 0/2] Configurable window titles for nodes Thomas Ellmenreich
2026-09-14 6:22 ` [PATCH manager v4 1/2] fix #5475: configurable window title Thomas Ellmenreich
2026-09-16 14:51 ` Arthur Bied-Charreton
2026-09-14 6:22 ` [PATCH cluster v4 2/2] " Thomas Ellmenreich
2026-09-16 14:52 ` Arthur Bied-Charreton [this message]
2026-09-16 15:02 ` [PATCH cluster/manager v4 0/2] Configurable window titles for nodes Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bz6atezurafzoiwp34m2x2k75ryr2pahoiblcqbor33banzppn@i2bmn3kdqrmn \
--to=a.bied-charreton@proxmox.com \
--cc=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.ellmenreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.