From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 36C0C1FF0A7 for ; Wed, 16 Sep 2026 17:02:15 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C71B8215C2; Wed, 16 Sep 2026 17:02:11 +0200 (CEST) Date: Wed, 16 Sep 2026 17:02:06 +0200 From: Arthur Bied-Charreton To: Thomas Ellmenreich Subject: Re: [PATCH cluster/manager v4 0/2] Configurable window titles for nodes Message-ID: <5h35rxtpbdrwc73authknhqye56otwanv2zwyb3qc4udoeim4i@ckxrjeokythc> References: <20260914062202.27182-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260914062202.27182-1-t.ellmenreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789570927111 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.441 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JHYUS45VPCDAJUMCO5XPTDIMGA5GCMAD X-Message-ID-Hash: JHYUS45VPCDAJUMCO5XPTDIMGA5GCMAD X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Sep 14, 2026 at 08:22:00AM +0200, Thomas Ellmenreich wrote: > Thank you @Dominik Csapak, @Thomas Lamprecht, @Elias Huhsovitz for your comments. > > Configurable window titles for nodes > ==================================== > > Currently the window title is fixed to the following string: > > $nodename - Proxmox Virtual Environment > > This has become problematic for users with multiple clusters, each containing > the same node name. To help distinguish between tabs, it has been requested [1] > that the window title be made configurable with the fqdn as an option. > > [1] https://bugzilla.proxmox.com/show_bug.cgi?id=5475 > > Implementation > -------------- > > After considering the different options, I have deemed a server side > implementation, through the datacenter.cfg, to be the better option. > Specifically because of its durability across sessions and because it > automatically configures the title for all users and all nodes across the > cluster. > > The config now contains a new ui-settings format string which then in turn > contains a 'title' enum field for the window title. This enum string will then > be converted to a window title and inserted in the index.html.tpl template on > every request. > > The current enum options are: > > - default - Displays the default '$nodename - Proxmox Virtual Environment' string > if the config enum is not present > > - 'node-and-cluster' - Displays the nodename and then the clustername in the > following style: '$nodename - $clustername - Proxmox Virtual Environment' > > - 'fqdn' - Displays the current fqdn as returned by `PVE::Tools::get_fqdn()` > like so: '$fqdn - Proxmox Virtual Environment' > > [...] thanks for the patches! tested node-and-cluster on a cluster and a standalone node, and fqdn; works as advertised. made a few comments to the pve-manager patch. I think the missing gettext calls and the window title fallback should be fixed in the next version, the rest are nits and one question. one other nit: since the pve-manager patch depends on the pve-cluster one, it would make more sense to put the pve-cluster patch first in the series.