* [PATCH container] lxc: remove unused find_lxc_console_pids helper
@ 2026-10-15 12:05 Filip Schauer
2026-10-15 12:26 ` Filip Schauer
0 siblings, 1 reply; 3+ messages in thread
From: Filip Schauer @ 2026-10-15 12:05 UTC (permalink / raw)
To: pve-devel
The helper is no longer needed, as its only user was the stale LXC
console reaper in pve-manager, which was removed in
888c136dd303 ("fix #8093: pvestatd: remove stale lxc console reaper").
Drop the now dead code.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
src/PVE/LXC.pm | 30 ------------------------------
1 file changed, 30 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 65a04a4..9c6b3d3 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -414,36 +414,6 @@ sub vmstatus {
return $list;
}
-sub find_lxc_console_pids {
-
- my $res = {};
-
- PVE::Tools::dir_glob_foreach(
- '/proc',
- '\d+',
- sub {
- my ($pid) = @_;
-
- my $cmdline = PVE::Tools::file_read_firstline("/proc/$pid/cmdline");
- return if !$cmdline;
-
- my @args = split(/\0/, $cmdline);
-
- # search for lxc-console -n <vmid>
- return if scalar(@args) != 3;
- return if $args[1] ne '-n';
- return if $args[2] !~ m/^\d+$/;
- return if $args[0] !~ m|^(/usr/bin/)?lxc-console$|;
-
- my $vmid = $args[2];
-
- push @{ $res->{$vmid} }, $pid;
- },
- );
-
- return $res;
-}
-
sub find_lxc_pid {
my ($vmid) = @_;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH container] lxc: remove unused find_lxc_console_pids helper
2026-10-15 12:05 [PATCH container] lxc: remove unused find_lxc_console_pids helper Filip Schauer
@ 2026-10-15 12:26 ` Filip Schauer
2026-10-19 9:13 ` superseded: " Filip Schauer
0 siblings, 1 reply; 3+ messages in thread
From: Filip Schauer @ 2026-10-15 12:26 UTC (permalink / raw)
To: pve-devel
This should only be applied once pve-manager is bumped to 9.2.22 or
whatever the next version ends up being.
We should also add the following to pve-container/debian/control:
```
Breaks: pve-manager (<< 9.2.22)
```
On 15/10/2026 14:06, Filip Schauer wrote:
> The helper is no longer needed, as its only user was the stale LXC
> console reaper in pve-manager, which was removed in
> 888c136dd303 ("fix #8093: pvestatd: remove stale lxc console reaper").
>
> Drop the now dead code.
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
> src/PVE/LXC.pm | 30 ------------------------------
> 1 file changed, 30 deletions(-)
>
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 65a04a4..9c6b3d3 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -414,36 +414,6 @@ sub vmstatus {
> return $list;
> }
>
> -sub find_lxc_console_pids {
> -
> - my $res = {};
> -
> - PVE::Tools::dir_glob_foreach(
> - '/proc',
> - '\d+',
> - sub {
> - my ($pid) = @_;
> -
> - my $cmdline = PVE::Tools::file_read_firstline("/proc/$pid/cmdline");
> - return if !$cmdline;
> -
> - my @args = split(/\0/, $cmdline);
> -
> - # search for lxc-console -n <vmid>
> - return if scalar(@args) != 3;
> - return if $args[1] ne '-n';
> - return if $args[2] !~ m/^\d+$/;
> - return if $args[0] !~ m|^(/usr/bin/)?lxc-console$|;
> -
> - my $vmid = $args[2];
> -
> - push @{ $res->{$vmid} }, $pid;
> - },
> - );
> -
> - return $res;
> -}
> -
> sub find_lxc_pid {
> my ($vmid) = @_;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* superseded: [PATCH container] lxc: remove unused find_lxc_console_pids helper
2026-10-15 12:26 ` Filip Schauer
@ 2026-10-19 9:13 ` Filip Schauer
0 siblings, 0 replies; 3+ messages in thread
From: Filip Schauer @ 2026-10-19 9:13 UTC (permalink / raw)
To: pve-devel
Superseded-by: https://lore.proxmox.com/pve-devel/20261019091112.34097-1-f.schauer@proxmox.com/
On 15/10/2026 14:27, Filip Schauer wrote:
> This should only be applied once pve-manager is bumped to 9.2.22 or
> whatever the next version ends up being.
>
> We should also add the following to pve-container/debian/control:
> ```
> Breaks: pve-manager (<< 9.2.22)
> ```
>
> On 15/10/2026 14:06, Filip Schauer wrote:
>> The helper is no longer needed, as its only user was the stale LXC
>> console reaper in pve-manager, which was removed in
>> 888c136dd303 ("fix #8093: pvestatd: remove stale lxc console reaper").
>>
>> Drop the now dead code.
>>
>> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
>> ---
>> src/PVE/LXC.pm | 30 ------------------------------
>> 1 file changed, 30 deletions(-)
>>
>> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
>> index 65a04a4..9c6b3d3 100644
>> --- a/src/PVE/LXC.pm
>> +++ b/src/PVE/LXC.pm
>> @@ -414,36 +414,6 @@ sub vmstatus {
>> return $list;
>> }
>> -sub find_lxc_console_pids {
>> -
>> - my $res = {};
>> -
>> - PVE::Tools::dir_glob_foreach(
>> - '/proc',
>> - '\d+',
>> - sub {
>> - my ($pid) = @_;
>> -
>> - my $cmdline = PVE::Tools::file_read_firstline("/proc/$pid/cmdline");
>> - return if !$cmdline;
>> -
>> - my @args = split(/\0/, $cmdline);
>> -
>> - # search for lxc-console -n <vmid>
>> - return if scalar(@args) != 3;
>> - return if $args[1] ne '-n';
>> - return if $args[2] !~ m/^\d+$/;
>> - return if $args[0] !~ m|^(/usr/bin/)?lxc-console$|;
>> -
>> - my $vmid = $args[2];
>> -
>> - push @{ $res->{$vmid} }, $pid;
>> - },
>> - );
>> -
>> - return $res;
>> -}
>> -
>> sub find_lxc_pid {
>> my ($vmid) = @_;
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-19 9:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-15 12:05 [PATCH container] lxc: remove unused find_lxc_console_pids helper Filip Schauer
2026-10-15 12:26 ` Filip Schauer
2026-10-19 9:13 ` superseded: " Filip Schauer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.