From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E599E1FF09C for ; Mon, 19 Oct 2026 11:13:41 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 27D88216BE; Mon, 19 Oct 2026 11:13:40 +0200 (CEST) Message-ID: <576c5a20-b5a1-4f9e-898b-d737d99dc7be@proxmox.com> Date: Mon, 19 Oct 2026 11:13:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: superseded: [PATCH container] lxc: remove unused find_lxc_console_pids helper From: Filip Schauer To: pve-devel@lists.proxmox.com References: <20261015120607.84307-1-f.schauer@proxmox.com> <1837ff9e-baf4-4325-bf2e-b88a4094bce1@proxmox.com> Content-Language: en-US In-Reply-To: <1837ff9e-baf4-4325-bf2e-b88a4094bce1@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792401214589 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.392 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RRLIMJRYMRGMXVLWNCY6BR3A2IAGUSC4 X-Message-ID-Hash: RRLIMJRYMRGMXVLWNCY6BR3A2IAGUSC4 X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded-by: https://lore.proxmox.com/pve-devel/20261019091112.34097-1-f.schauer@proxmox.com/ On 15/10/2026 14:27, Filip Schauer wrote: > This should only be applied once pve-manager is bumped to 9.2.22 or > whatever the next version ends up being. > > We should also add the following to pve-container/debian/control: > ``` > Breaks: pve-manager (<< 9.2.22) > ``` > > On 15/10/2026 14:06, Filip Schauer wrote: >> The helper is no longer needed, as its only user was the stale LXC >> console reaper in pve-manager, which was removed in >> 888c136dd303 ("fix #8093: pvestatd: remove stale lxc console reaper"). >> >> Drop the now dead code. >> >> Signed-off-by: Filip Schauer >> --- >>   src/PVE/LXC.pm | 30 ------------------------------ >>   1 file changed, 30 deletions(-) >> >> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm >> index 65a04a4..9c6b3d3 100644 >> --- a/src/PVE/LXC.pm >> +++ b/src/PVE/LXC.pm >> @@ -414,36 +414,6 @@ sub vmstatus { >>       return $list; >>   } >> -sub find_lxc_console_pids { >> - >> -    my $res = {}; >> - >> -    PVE::Tools::dir_glob_foreach( >> -        '/proc', >> -        '\d+', >> -        sub { >> -            my ($pid) = @_; >> - >> -            my $cmdline = PVE::Tools::file_read_firstline("/proc/$pid/cmdline"); >> -            return if !$cmdline; >> - >> -            my @args = split(/\0/, $cmdline); >> - >> -            # search for lxc-console -n >> -            return if scalar(@args) != 3; >> -            return if $args[1] ne '-n'; >> -            return if $args[2] !~ m/^\d+$/; >> -            return if $args[0] !~ m|^(/usr/bin/)?lxc-console$|; >> - >> -            my $vmid = $args[2]; >> - >> -            push @{ $res->{$vmid} }, $pid; >> -        }, >> -    ); >> - >> -    return $res; >> -} >> - >>   sub find_lxc_pid { >>       my ($vmid) = @_; > > > > >