From: Christian Ebner <c.ebner@proxmox.com>
To: Jonas Theisen <j.theisen@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v4 3/9] server: schedules: add 'disable' parameter to compute_schedule_status()
Date: Tue, 27 Oct 2026 12:53:46 +0100 [thread overview]
Message-ID: <2ac12855-1ff1-4243-acc8-6319224f5169@proxmox.com> (raw)
In-Reply-To: <20261022164343.353831-4-j.theisen@proxmox.com>
On 10/22/26 6:44 PM, Jonas Theisen wrote:
> To properly calculate the next_run for jobs the scheduler needs
> to know if the job is currently disabled.
>
> This commit adds the parameter to the function and sets the
> next_run property to None if the job is disabled.
>
> This is equivalent to no or an invalid schedule.
>
> All callers are adapted to pass the disable flag of their job. For
> prune jobs this replaces the manual reset of next_run for disabled
> jobs.
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
This depends on
https://lore.proxmox.com/pbs-devel/bf2a12b0-b1e9-4dd6-8345-5defe91723a0@proxmox.com/T/#t
being applied first.
next prev parent reply other threads:[~2026-10-27 11:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 16:43 [PATCH proxmox{,-backup} v4 0/9] fix #7904: Implement Enable checkboxes for all jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox v4 1/9] pbs-api-types: add 'disable' to {sync,verify,tape,gc} job schema and datastore config Jonas Theisen
2026-10-27 11:33 ` Christian Ebner
2026-10-22 16:43 ` [PATCH proxmox v4 2/9] pbs-api-types: prune job: make schedule optional Jonas Theisen
2026-10-27 12:49 ` Christian Ebner
2026-10-22 16:43 ` [PATCH proxmox-backup v4 3/9] server: schedules: add 'disable' parameter to compute_schedule_status() Jonas Theisen
2026-10-27 11:53 ` Christian Ebner [this message]
2026-10-22 16:43 ` [PATCH proxmox-backup v4 4/9] ui: prune job: align prune edit window to other "Enable" checkboxes Jonas Theisen
2026-10-27 12:48 ` Christian Ebner
2026-10-22 16:43 ` [PATCH proxmox-backup v4 5/9] api: prune job: align prune job schedule to other jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 6/9] fix #7904: api: implement "disable" for {sync,verify,tape,GC} jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 7/9] fix #7904: ui: add "Enable" checkbox to {sync,verify,tape,GC} job edit Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 8/9] ui: job overview: show "Disabled" as schedule of disabled jobs Jonas Theisen
2026-10-22 16:43 ` [PATCH proxmox-backup v4 9/9] ui: calendar-event: hide clear button if a schedule is required Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac12855-1ff1-4243-acc8-6319224f5169@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=j.theisen@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.