From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id B02771FF0B0
	for <inbox@lore.proxmox.com>; Tue, 27 Oct 2026 12:53:51 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 2B1A020AF0;
	Tue, 27 Oct 2026 12:53:51 +0100 (CET)
Message-ID: <2ac12855-1ff1-4243-acc8-6319224f5169@proxmox.com>
Date: Tue, 27 Oct 2026 12:53:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH proxmox-backup v4 3/9] server: schedules: add 'disable'
 parameter to compute_schedule_status()
To: Jonas Theisen <j.theisen@proxmox.com>, pbs-devel@lists.proxmox.com
References: <20261022164343.353831-1-j.theisen@proxmox.com>
 <20261022164343.353831-4-j.theisen@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <20261022164343.353831-4-j.theisen@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793102027250
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.497 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: YZKIJHIAXCSZECNHAM2UNMIGPPI6N5GD
X-Message-ID-Hash: YZKIJHIAXCSZECNHAM2UNMIGPPI6N5GD
X-MailFrom: c.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On 10/22/26 6:44 PM, Jonas Theisen wrote:
> To properly calculate the next_run for jobs the scheduler needs
> to know if the job is currently disabled.
> 
> This commit adds the parameter to the function and sets the
> next_run property to None if the job is disabled.
> 
> This is equivalent to no or an invalid schedule.
> 
> All callers are adapted to pass the disable flag of their job. For
> prune jobs this replaces the manual reset of next_run for disabled
> jobs.
> 
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>

This depends on 
https://lore.proxmox.com/pbs-devel/bf2a12b0-b1e9-4dd6-8345-5defe91723a0@proxmox.com/T/#t 
being applied first.