[PATCH proxmox-backup v4 9/9] ui: calendar-event: hide clear button if a schedule is required

[Jonas Theisen <j.theisen@proxmox.com>]

Since the schedule fields of the job edit windows do not allow
empty inputs anymore, offering a clear button there is
unintuitive.

Only show the clear button if the field allows empty values. Fields
that may still be left empty, like the GC and prune schedules when
creating a datastore or the threshold reset schedule, keep it.

Also update the button's visibility when the value is set, not only
on change events. Initial values, like the default prune schedule
when creating a datastore, do not fire a change event, so the button
was previously only shown after the value had been changed manually.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/form/CalendarEvent.js | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/www/form/CalendarEvent.js b/www/form/CalendarEvent.js
index b050da694..1ad0c0a87 100644
--- a/www/form/CalendarEvent.js
+++ b/www/form/CalendarEvent.js
@@ -59,17 +59,26 @@ Ext.define('PBS.form.CalendarEvent', {
             weight: -1,
             hidden: true,
             handler: function () {
-                this.triggers.clear.setVisible(false);
                 this.setValue('');
             },
         },
     },
 
+    updateClearTrigger: function (value) {
+        let me = this;
+        let empty = Ext.isArray(value) ? !value.length : !value;
+        me.triggers.clear.setVisible(!empty && me.allowBlank);
+    },
+
+    // also called for the initial value, which does not fire a change event
+    setValue: function (value) {
+        let me = this;
+        me.updateClearTrigger(value);
+        return me.callParent([value]);
+    },
+
     listeners: {
-        change: function (field, value) {
-            let canClear = (value ?? '') !== '';
-            field.triggers.clear.setVisible(canClear);
-        },
+        change: (field, value) => field.updateClearTrigger(value),
     },
 
     store: {
-- 
2.47.3