all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager/storage 0/3] san: show and check for missing open-iscsi on nodes
Date: Fri, 20 Nov 2026 13:51:52 +0100	[thread overview]
Message-ID: <20261120125236.2393788-1-d.csapak@proxmox.com> (raw)

When open-iscsi is not installed on a node, the iSCSI guided setup
still showed it as 'OK' and let one select it, since the node list only
shows the multipath state. The iSCSI storage then can't be activated
on that node.

This series makes the nodes only report their initiator name in the
multipath status if open-iscsi is installed (it could otherwise be a
leftover of a removed but not purged open-iscsi), and uses that in the
UI:

* the guided setup shows such nodes as 'open-iscsi not installed' and
  won't continue if one of them is selected
* the SAN view shows it in the initiator name column (not as state,
  since a node does not need open-iscsi if it only uses e.g. Fibre
  Channel)

Without the pve-storage patch (e.g. on nodes that are not upgraded
yet), only nodes where open-iscsi was never installed or was purged
are detected, since the others still report a leftover name.

Alternatively we could of course hard-depend on open-iscsi, then
we can be sure that all properly updated nodes have it.

pve-storage:

Dominik Csapak (1):
  multipath: status: only report initiator name if open-iscsi is
    installed

 src/PVE/API2/Multipath.pm           |  2 +-
 src/PVE/Multipath/Status.pm         |  9 ++++++---
 src/test/run_multipath_api_tests.pl | 16 ++++++++++++----
 3 files changed, 19 insertions(+), 8 deletions(-)


pve-manager:

Dominik Csapak (2):
  ui: san: iscsi guided setup: don't allow nodes without open-iscsi
  ui: dc: san: show missing open-iscsi in the node grid

 www/manager6/SANUtils.js                      | 14 ++++++++++
 www/manager6/dc/SAN.js                        |  7 ++++-
 www/manager6/storage/wizard/IScsi.js          | 28 +++++++++++++++++++
 www/manager6/storage/wizard/NodeIdentities.js | 16 +++++++++--
 4 files changed, 61 insertions(+), 4 deletions(-)


Summary over all repositories:
  7 files changed, 80 insertions(+), 12 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-11-20 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:51 Dominik Csapak [this message]
2026-11-20 12:51 ` [PATCH pve-storage 1/3] multipath: status: only report initiator name if open-iscsi is installed Dominik Csapak
2026-11-20 12:51 ` [PATCH pve-manager 2/3] ui: san: iscsi guided setup: don't allow nodes without open-iscsi Dominik Csapak
2026-11-20 12:51 ` [PATCH pve-manager 3/3] ui: dc: san: show missing open-iscsi in the node grid Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120125236.2393788-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal