From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 3/3] ui: dc: san: show missing open-iscsi in the node grid
Date: Fri, 20 Nov 2026 13:51:55 +0100 [thread overview]
Message-ID: <20261120125236.2393788-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20261120125236.2393788-1-d.csapak@proxmox.com>
show 'open-iscsi not installed' instead of the initiator name for
nodes that don't report one.
Don't show it as state, since a node does not need open-iscsi if it
only uses e.g. Fibre Channel, so it's not an error there.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/SANUtils.js | 8 ++++++++
www/manager6/dc/SAN.js | 7 ++++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/www/manager6/SANUtils.js b/www/manager6/SANUtils.js
index 90ddd1eb..ed76ce40 100644
--- a/www/manager6/SANUtils.js
+++ b/www/manager6/SANUtils.js
@@ -129,6 +129,14 @@ Ext.define('PVE.SANUtils', {
return report.state !== 'no-report' && !report['iscsi-initiator-name'];
},
+ renderInitiatorName: function (value, metaData, rec) {
+ if (rec.get('iscsi-missing')) {
+ let text = Ext.htmlEncode(gettext('open-iscsi not installed'));
+ return `<i class="fa fa-fw fa-info-circle faded"></i> ${text}`;
+ }
+ return Ext.htmlEncode(value);
+ },
+
renderState: function (value) {
if (!value) {
return '';
diff --git a/www/manager6/dc/SAN.js b/www/manager6/dc/SAN.js
index 530d96a1..d55a2339 100644
--- a/www/manager6/dc/SAN.js
+++ b/www/manager6/dc/SAN.js
@@ -9,6 +9,11 @@ Ext.define('pve-san-status', {
'apply-error',
'time',
'iscsi-initiator-name',
+ {
+ name: 'iscsi-missing',
+ depends: ['kind', 'state', 'iscsi-initiator-name'],
+ calculate: (data) => data.kind === 'node' && PVE.SANUtils.iscsiMissing(data),
+ },
'other-maps',
'wwid',
'name',
@@ -175,7 +180,7 @@ Ext.define('PVE.dc.SANView', {
text: gettext('iSCSI Initiator Name'),
dataIndex: 'iscsi-initiator-name',
flex: 2,
- renderer: Ext.htmlEncode,
+ renderer: PVE.SANUtils.renderInitiatorName,
},
{
text: gettext('Other Maps'),
--
2.47.3
prev parent reply other threads:[~2026-11-20 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 12:51 [PATCH manager/storage 0/3] san: show and check for missing open-iscsi on nodes Dominik Csapak
2026-11-20 12:51 ` [PATCH pve-storage 1/3] multipath: status: only report initiator name if open-iscsi is installed Dominik Csapak
2026-11-20 12:51 ` [PATCH pve-manager 2/3] ui: san: iscsi guided setup: don't allow nodes without open-iscsi Dominik Csapak
2026-11-20 12:51 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120125236.2393788-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.