From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 093D91FF0AF for ; Fri, 20 Nov 2026 13:52:48 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 38E482173B; Fri, 20 Nov 2026 13:52:40 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager/storage 0/3] san: show and check for missing open-iscsi on nodes Date: Fri, 20 Nov 2026 13:51:52 +0100 Message-ID: <20261120125236.2393788-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.270 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LVZNGFAUDEQDHVQ3W7IYXGEJAO6TPVZI X-Message-ID-Hash: LVZNGFAUDEQDHVQ3W7IYXGEJAO6TPVZI X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When open-iscsi is not installed on a node, the iSCSI guided setup still showed it as 'OK' and let one select it, since the node list only shows the multipath state. The iSCSI storage then can't be activated on that node. This series makes the nodes only report their initiator name in the multipath status if open-iscsi is installed (it could otherwise be a leftover of a removed but not purged open-iscsi), and uses that in the UI: * the guided setup shows such nodes as 'open-iscsi not installed' and won't continue if one of them is selected * the SAN view shows it in the initiator name column (not as state, since a node does not need open-iscsi if it only uses e.g. Fibre Channel) Without the pve-storage patch (e.g. on nodes that are not upgraded yet), only nodes where open-iscsi was never installed or was purged are detected, since the others still report a leftover name. Alternatively we could of course hard-depend on open-iscsi, then we can be sure that all properly updated nodes have it. pve-storage: Dominik Csapak (1): multipath: status: only report initiator name if open-iscsi is installed src/PVE/API2/Multipath.pm | 2 +- src/PVE/Multipath/Status.pm | 9 ++++++--- src/test/run_multipath_api_tests.pl | 16 ++++++++++++---- 3 files changed, 19 insertions(+), 8 deletions(-) pve-manager: Dominik Csapak (2): ui: san: iscsi guided setup: don't allow nodes without open-iscsi ui: dc: san: show missing open-iscsi in the node grid www/manager6/SANUtils.js | 14 ++++++++++ www/manager6/dc/SAN.js | 7 ++++- www/manager6/storage/wizard/IScsi.js | 28 +++++++++++++++++++ www/manager6/storage/wizard/NodeIdentities.js | 16 +++++++++-- 4 files changed, 61 insertions(+), 4 deletions(-) Summary over all repositories: 7 files changed, 80 insertions(+), 12 deletions(-) -- Generated by murpp 0.11.0