all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH common 0/2] Adding D state checking to the run command
@ 2026-11-19 14:50 Jordyn Hamilton
  2026-11-19 14:50 ` [PATCH common 1/2] Added subroutine to check process status Jordyn Hamilton
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Jordyn Hamilton @ 2026-11-19 14:50 UTC (permalink / raw)
  To: pve-devel; +Cc: j.hamilton, c.hughes

Currently the run command does not have any logic branches to check for
a D state. This can cause certain processes like `pvereport` to hang
indefinitely if it encounters a subprocess that ends up in this state.

Adding a logic branch off the timeout error branch to check for a D
state process that, if encountered, throws a meaningful error and
terminates. Due to the nature of D states, there is no way to
programatically fix or terminate a process in a D state, so the error
message contains the command, the process id, and first steps towards
debugging.

This change wasn't designed as opt-in/out due to the fact that a D
state would cause whatever process that calls it to hang indefinitely,
without proper termination or error messaging, and universally, having a
proper termination with an error message would provide a better user and
support experience.

Jordyn Hamilton (2):
  Added subroutine to check process status
  Added logic to check for d state to run subroutine

 src/PVE/Cmd.pm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

-- 
2.47.3





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-19 18:49 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 14:50 [PATCH common 0/2] Adding D state checking to the run command Jordyn Hamilton
2026-11-19 14:50 ` [PATCH common 1/2] Added subroutine to check process status Jordyn Hamilton
2026-11-19 15:33   ` Shannon Sterz
2026-11-19 14:50 ` [PATCH common 2/2] Added logic to check for d state to run subroutine Jordyn Hamilton
2026-11-19 15:33   ` Shannon Sterz
2026-11-19 15:33 ` [PATCH common 0/2] Adding D state checking to the run command Shannon Sterz
2026-11-19 18:49 ` superseded " Jordyn Hamilton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal