From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 844E71FF0DA for ; Thu, 19 Nov 2026 16:33:51 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 61589216B4; Thu, 19 Nov 2026 16:33:50 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Nov 2026 16:33:46 +0100 Message-Id: Subject: Re: [PATCH common 0/2] Adding D state checking to the run command To: "Jordyn Hamilton" , X-Mailer: aerc 0.20.0 References: <20261119145011.8017-1-j.hamilton@proxmox.com> In-Reply-To: <20261119145011.8017-1-j.hamilton@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795102426160 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.538 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MTAHQ2Y4T2E55KQCXFGH3DFIQFJLGZ24 X-Message-ID-Hash: MTAHQ2Y4T2E55KQCXFGH3DFIQFJLGZ24 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: c.hughes@proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 19, 2026 at 3:50 PM CET, Jordyn Hamilton wrote: > Currently the run command does not have any logic branches to check for > a D state. This can cause certain processes like `pvereport` to hang > indefinitely if it encounters a subprocess that ends up in this state. > > Adding a logic branch off the timeout error branch to check for a D > state process that, if encountered, throws a meaningful error and > terminates. Due to the nature of D states, there is no way to > programatically fix or terminate a process in a D state, so the error > message contains the command, the process id, and first steps towards > debugging. > > This change wasn't designed as opt-in/out due to the fact that a D > state would cause whatever process that calls it to hang indefinitely, > without proper termination or error messaging, and universally, having a > proper termination with an error message would provide a better user and > support experience. > > Jordyn Hamilton (2): > Added subroutine to check process status > Added logic to check for d state to run subroutine > > src/PVE/Cmd.pm | 24 +++++++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) Hi Jordyn, thank you for your patches! Sadly they don't apply on top of current master cleanly anymore, so I couldn't test them. I left a few nits, and imo, it would be fine to combine the changes here into a single patch.