[PATCH perl-rs/proxmox v2 0/3] perl: enable strict and warnings in modules that lack them

[PATCH perl-rs/proxmox v2 0/3] perl: enable strict and warnings in modules that lack them

[Lukas Sichert]

A scan of the perl modules in these repositories found a few that
enable neither 'use v5.36' nor 'use strict' and 'use warnings'. Enable
them to adhere to the style guide and so that mistakes such as typos
in variable names or uses of undefined values do not go unnoticed.

The Fixup.pm files in pve-rs and pmg-rs are intentionally left alone.
They are not modules of their own, but snippets that perlmod's
genpackage.pl inserts into the generated Proxmox::Lib::PVE and
Proxmox::Lib::PMG right after the 'use strict; use warnings;' of its
template, so they already run under both pragmas.

Testing:
- proxmox: running 'make refresh' in pve-api-types before and after the
  change generates identical output and identical stderr.
- perl-rs: syntax check and including the common file with perl -e
  returned no warnings

Changes v1 -> v2:
- removed the pve-network patch as it is already applied
- deleted the CalendarEvent files instead of enabling strict and warnings
- enable v5.36 instead of strict and warnings in proxmox


perl-rs:

Lukas Sichert (2):
  common: remove deprecated PVE::RS::CalendarEvent compat module
  common: enable v5.36 in Proxmox::Lib::Common

 common/pkg/PVE/RS/CalendarEvent.pm | 3 ---
 common/pkg/Proxmox/Lib/Common.pm   | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
 delete mode 100644 common/pkg/PVE/RS/CalendarEvent.pm


proxmox:

Lukas Sichert (1):
  pve-api-types: enable v5.36 in Bool

 pve-api-types/generator-lib/Bool.pm | 2 ++
 1 file changed, 2 insertions(+)


Summary over all repositories:
  3 files changed, 4 insertions(+), 3 deletions(-)

-- 
Generated by murpp 0.12.0

[PATCH perl-rs v2 1/3] common: remove deprecated PVE::RS::CalendarEvent compat module

[Lukas Sichert]

PVE::RS::CalendarEvent only provided Proxmox::RS::CalendarEvent under
its old name by using it as base and has been deprecated since the
package was renamed. Nothing in the pve and perl-rs repositories
references it any more, so drop it.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---

Notes:
    Changes v1 -> v2:
    - new patch, delete the CalendarEvent file instead of enabling strict
      and warnings in it

 common/pkg/PVE/RS/CalendarEvent.pm | 3 ---
 1 file changed, 3 deletions(-)
 delete mode 100644 common/pkg/PVE/RS/CalendarEvent.pm

diff --git a/common/pkg/PVE/RS/CalendarEvent.pm b/common/pkg/PVE/RS/CalendarEvent.pm
deleted file mode 100644
index 3a5f66e..0000000
--- a/common/pkg/PVE/RS/CalendarEvent.pm
+++ /dev/null
@@ -1,3 +0,0 @@
-use base 'Proxmox::RS::CalendarEvent';
-# Compat, Deprecated!
-1
-- 
2.47.3

[PATCH perl-rs v2 2/3] common: enable v5.36 in Proxmox::Lib::Common

[Lukas Sichert]

The Proxmox style guide requires every perl module to enable strict
and warnings, but Proxmox::Lib::Common did not. Enable v5.36 as this
also includes these pragmas.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---

Notes:
    Changes v1 -> v2:
    - enable v5.36 instead of strict and warnings

 common/pkg/Proxmox/Lib/Common.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/pkg/Proxmox/Lib/Common.pm b/common/pkg/Proxmox/Lib/Common.pm
index 1e6b26d..ca358c4 100644
--- a/common/pkg/Proxmox/Lib/Common.pm
+++ b/common/pkg/Proxmox/Lib/Common.pm
@@ -22,6 +22,8 @@ whichever was loaded.
 
 =cut
 
+use v5.36;
+
 use vars qw(@ISA);
 
 sub library {
-- 
2.47.3

[PATCH proxmox v2 3/3] pve-api-types: enable v5.36 in Bool

[Lukas Sichert]

The Proxmox style guide requires every perl module to enable strict
and warnings, but Bool.pm did not. Enable v5.36 as this also includes
these pragmas.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---

Notes:
    Changes v1 -> v2:
    - enable v5.36 instead of strict and warnings

 pve-api-types/generator-lib/Bool.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pve-api-types/generator-lib/Bool.pm b/pve-api-types/generator-lib/Bool.pm
index 12a4e156..f1a9ea9d 100644
--- a/pve-api-types/generator-lib/Bool.pm
+++ b/pve-api-types/generator-lib/Bool.pm
@@ -1,5 +1,7 @@
 package Bool;
 
+use v5.36;
+
 use base 'Exporter';
 use overload
     '!' => sub { bool(!$_[0]->$*) },
-- 
2.47.3