all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH perl-rs/proxmox v2 0/3] perl: enable strict and warnings in modules that lack them
Date: Thu,  5 Nov 2026 10:41:01 +0100	[thread overview]
Message-ID: <20261105094124.42373-1-l.sichert@proxmox.com> (raw)

A scan of the perl modules in these repositories found a few that
enable neither 'use v5.36' nor 'use strict' and 'use warnings'. Enable
them to adhere to the style guide and so that mistakes such as typos
in variable names or uses of undefined values do not go unnoticed.

The Fixup.pm files in pve-rs and pmg-rs are intentionally left alone.
They are not modules of their own, but snippets that perlmod's
genpackage.pl inserts into the generated Proxmox::Lib::PVE and
Proxmox::Lib::PMG right after the 'use strict; use warnings;' of its
template, so they already run under both pragmas.

Testing:
- proxmox: running 'make refresh' in pve-api-types before and after the
  change generates identical output and identical stderr.
- perl-rs: syntax check and including the common file with perl -e
  returned no warnings

Changes v1 -> v2:
- removed the pve-network patch as it is already applied
- deleted the CalendarEvent files instead of enabling strict and warnings
- enable v5.36 instead of strict and warnings in proxmox


perl-rs:

Lukas Sichert (2):
  common: remove deprecated PVE::RS::CalendarEvent compat module
  common: enable v5.36 in Proxmox::Lib::Common

 common/pkg/PVE/RS/CalendarEvent.pm | 3 ---
 common/pkg/Proxmox/Lib/Common.pm   | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
 delete mode 100644 common/pkg/PVE/RS/CalendarEvent.pm


proxmox:

Lukas Sichert (1):
  pve-api-types: enable v5.36 in Bool

 pve-api-types/generator-lib/Bool.pm | 2 ++
 1 file changed, 2 insertions(+)


Summary over all repositories:
  3 files changed, 4 insertions(+), 3 deletions(-)

-- 
Generated by murpp 0.12.0




             reply	other threads:[~2026-11-05  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  9:41 Lukas Sichert [this message]
2026-11-05  9:41 ` [PATCH perl-rs v2 1/3] common: remove deprecated PVE::RS::CalendarEvent compat module Lukas Sichert
2026-11-05  9:41 ` [PATCH perl-rs v2 2/3] common: enable v5.36 in Proxmox::Lib::Common Lukas Sichert
2026-11-05  9:41 ` [PATCH proxmox v2 3/3] pve-api-types: enable v5.36 in Bool Lukas Sichert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261105094124.42373-1-l.sichert@proxmox.com \
    --to=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal