[PATCH pve-manager v3 16/16] ui: guest destroy: add control for dangling IPSet references

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Destroying a guest releases its IPAM entries, so the auto-generated
'guest-ipam-<vmid>' IPSet disappears with it. Rules referencing that
IPSet do not resolve anymore and are silently dropped from the
generated ruleset.

Add the shared selector to the destroy dialog, so those rules can be
disabled or deleted along with the guest, next to a hint linking to
the SDN firewall integration documentation. 'keep' remains the
default, matching the API.

The 'note' config only renders a single hint, so it is replaced by
two display fields among the additional items.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/window/SafeDestroyGuest.js | 44 ++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/www/manager6/window/SafeDestroyGuest.js b/www/manager6/window/SafeDestroyGuest.js
index 45b277e5..45099342 100644
--- a/www/manager6/window/SafeDestroyGuest.js
+++ b/www/manager6/window/SafeDestroyGuest.js
@@ -32,7 +32,46 @@ Ext.define('PVE.window.SafeDestroyGuest', {
         },
     ],
 
-    note: gettext('Referenced disks will always be destroyed.'),
+    initComponent: function () {
+        let me = this;
+
+        let helpLink = Ext.htmlEncode(Proxmox.Utils.get_help_link('pvesdn_firewall_integration'));
+        let helpLabel = Ext.htmlEncode(gettext('this guest\'s auto-generated IPSet'));
+        let refsHint = Ext.String.format(
+            gettext('Firewall rules referencing {0} will no longer resolve.'),
+            `<a target="_blank" href="${helpLink}">${helpLabel}</a>`,
+        );
+
+        me.additionalItems = [
+            // build fresh array per instance, pushing would append every time the dialog is opened
+            ...me.additionalItems,
+            {
+                xtype: 'displayfield',
+                userCls: 'pmx-hint',
+                value: gettext('Referenced disks will always be destroyed.'),
+            },
+            {
+                xtype: 'displayfield',
+                userCls: 'pmx-hint',
+                value: refsHint,
+            },
+            {
+                xtype: 'pveFirewallDanglingReferences',
+                reference: 'firewallDanglingReferencesButton',
+                value: 'keep',
+                labelWidth: 200,
+                keepTip: gettext(
+                    'Keep referencing rules. They are dropped from the generated ruleset and shown as invalid until a guest with the same VMID is recreated.',
+                ),
+                disableTip: gettext(
+                    'Disable referencing rules, keeping them in the firewall configuration.',
+                ),
+                dropTip: gettext('Delete referencing rules.'),
+            },
+        ];
+
+        me.callParent();
+    },
 
     getParams: function () {
         let me = this;
@@ -43,6 +82,9 @@ Ext.define('PVE.window.SafeDestroyGuest', {
         let destroyUnreferencedCheckbox = me.lookupReference('destroyUnreferencedCheckbox');
         me.params['destroy-unreferenced-disks'] = destroyUnreferencedCheckbox.checked ? 1 : 0;
 
+        let danglingRefs = me.lookupReference('firewallDanglingReferencesButton');
+        me.params['dangling-ipset-references'] = danglingRefs.getValue();
+
         return me.callParent();
     },
 });
-- 
2.47.3