all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: SPAM: [PATCH pve-manager v3 11/16] ui: firewall: add common widgets for deleting and updating references
Date: Fri, 25 Sep 2026 11:42:25 +0200	[thread overview]
Message-ID: <20260925094230.844917-12-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20260925094230.844917-1-a.bied-charreton@proxmox.com>

The ipset and alias grids need the same two UI pieces to let users
update/delete referencing rules when removing or renaming an object. Add
them as reusable components.

FirewallObjectRemove extends ConfirmRemoveDialog with a
keep/disable/drop selector that sets 'dangling-references',
FirewallUpdateReferences is a no/yes/force selector that submits
'update-references'.

Callers will be added in subsequent commits.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/Makefile                     |   1 +
 www/manager6/grid/FirewallObjectCommon.js | 143 ++++++++++++++++++++++
 2 files changed, 144 insertions(+)
 create mode 100644 www/manager6/grid/FirewallObjectCommon.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index d2ea786b..e211ad40 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -98,6 +98,7 @@ JSSRC= 							\
 	form/TagFieldSet.js				\
 	form/IsoSelector.js				\
 	grid/BackupView.js				\
+	grid/FirewallObjectCommon.js		\
 	grid/FirewallAliases.js				\
 	grid/FirewallOptions.js				\
 	grid/FirewallRules.js				\
diff --git a/www/manager6/grid/FirewallObjectCommon.js b/www/manager6/grid/FirewallObjectCommon.js
new file mode 100644
index 00000000..75c012b5
--- /dev/null
+++ b/www/manager6/grid/FirewallObjectCommon.js
@@ -0,0 +1,143 @@
+Ext.define('PVE.window.FirewallObjectRemove', {
+    extend: 'Proxmox.window.ConfirmRemoveDialog',
+    alias: 'widget.pveFirewallObjectRemove',
+
+    width: 500,
+
+    keepTip: undefined,
+    disableTip: undefined,
+    dropTip: undefined,
+
+    initComponent: function () {
+        let me = this;
+
+        me.additionalItems = [
+            {
+                xtype: 'pveFirewallDanglingReferences',
+                keepTip: me.keepTip,
+                disableTip: me.disableTip,
+                dropTip: me.dropTip,
+            },
+        ];
+
+        me.callParent();
+    },
+
+    getParams: function () {
+        let me = this;
+
+        // do not write into the shared config default, it outlives this dialog
+        me.params = Ext.applyIf(
+            { 'dangling-references': me.down('pveFirewallDanglingReferences').getValue() },
+            me.params,
+        );
+
+        return me.callParent();
+    },
+});
+
+Ext.define('PVE.form.FirewallUpdateReferences', {
+    extend: 'Ext.form.FieldContainer',
+    alias: 'widget.pveFirewallUpdateReferences',
+
+    fieldLabel: gettext('Update references'),
+    labelWidth: 150,
+    layout: { type: 'hbox', pack: 'end' },
+
+    // submitted parameter
+    name: 'update-references',
+    value: 'no',
+
+    noTip: undefined,
+    yesTip: undefined,
+    forceTip: undefined,
+
+    initComponent: function () {
+        let me = this;
+
+        for (const tip of ['noTip', 'yesTip', 'forceTip']) {
+            if (me[tip] === undefined) {
+                throw new Error(`${tip} is undefined, cannot initialize component`);
+            }
+        }
+
+        me.items = [
+            {
+                xtype: 'segmentedbutton',
+                allowMultiple: false,
+                value: me.value,
+                items: [
+                    { text: gettext('No'), value: 'no', tooltip: me.noTip },
+                    { text: gettext('Yes'), value: 'yes', tooltip: me.yesTip },
+                    { text: gettext('Force'), value: 'force', tooltip: me.forceTip },
+                ],
+                listeners: {
+                    change: (btn, val) => me.down('hiddenfield').setValue(val),
+                },
+            },
+            {
+                xtype: 'hiddenfield',
+                name: me.name,
+                value: me.value,
+                isDirty: () => false,
+            },
+        ];
+
+        me.callParent();
+    },
+});
+
+Ext.define('PVE.form.FirewallDanglingReferences', {
+    extend: 'Ext.form.FieldContainer',
+    alias: 'widget.pveFirewallDanglingReferences',
+
+    fieldLabel: gettext('Referencing rules'),
+    labelWidth: 200,
+    layout: { type: 'hbox', pack: 'end' },
+
+    // submitted parameter
+    name: 'dangling-references',
+    value: 'disable',
+
+    keepTip: undefined,
+    disableTip: undefined,
+    dropTip: undefined,
+
+    getValue: function () {
+        return this.down('hiddenfield').getValue();
+    },
+
+    initComponent: function () {
+        let me = this;
+
+        for (const tip of ['keepTip', 'disableTip', 'dropTip']) {
+            if (me[tip] === undefined) {
+                throw new Error(`${tip} is undefined, cannot initialize component`);
+            }
+        }
+
+        me.items = [
+            {
+                xtype: 'segmentedbutton',
+                allowMultiple: false,
+                value: me.value,
+                items: [
+                    { text: gettext('Keep'), value: 'keep', tooltip: me.keepTip },
+                    { text: gettext('Disable'), value: 'disable', tooltip: me.disableTip },
+                    { text: gettext('Delete'), value: 'drop', tooltip: me.dropTip },
+                ],
+                listeners: {
+                    change: (btn, val) => me.down('hiddenfield').setValue(val),
+                },
+            },
+            {
+                xtype: 'hiddenfield',
+                name: me.name,
+                value: me.value,
+                isDirty: () => false,
+            },
+        ];
+
+        me.callParent();
+    },
+});
-- 
2.47.3




  parent reply	other threads:[~2026-09-25  9:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25  9:42 SPAM: [PATCH container/firewall/manager/network/qemu-server v3 00/16] handle dangling references when firewall objects go away Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-firewall v3 01/16] helpers: add helpers to update firewall object references Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-firewall v3 02/16] parser: do not log errors for disabled rules Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-firewall v3 03/16] api: ipset: add option to update references on edit Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-firewall v3 04/16] api: ipset: add option to handle dangling references on delete Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-firewall v3 05/16] api: aliases: add option to update references on edit Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-firewall v3 06/16] api: aliases: add option to handle dangling references on delete Arthur Bied-Charreton
2026-09-25  9:42 ` SPAM: [PATCH pve-firewall v3 07/16] firewall: tests: add tests for object reference update logic Arthur Bied-Charreton
2026-09-25  9:42 ` SPAM: [PATCH pve-network v3 08/16] apply: add option to handle dangling references on VNet deletion Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH qemu-server v3 09/16] api: destroy_vm: add option to handle dangling IPSet references Arthur Bied-Charreton
2026-09-25  9:42 ` SPAM: [PATCH pve-container v3 10/16] " Arthur Bied-Charreton
2026-09-25  9:42 ` Arthur Bied-Charreton [this message]
2026-09-25  9:42 ` [PATCH pve-manager v3 12/16] ui: firewall: ipset: add controls to update/delete references on edit Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-manager v3 13/16] ui: firewall: aliases: " Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-manager v3 14/16] ui: sdn: apply: add control for dangling IPSet references Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-manager v3 15/16] ui: guest destroy: use let for non-constant variable bindings Arthur Bied-Charreton
2026-09-25  9:42 ` [PATCH pve-manager v3 16/16] ui: guest destroy: add control for dangling IPSet references Arthur Bied-Charreton
2026-09-25 11:05 ` SPAM: [PATCH container/firewall/manager/network/qemu-server v3 00/16] handle dangling references when firewall objects go away Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925094230.844917-12-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal