[PATCH pve-manager v3 13/16] ui: firewall: aliases: add controls to update/delete references on edit

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Add the shared 'update-references' selector to the update dialog, so a
rename can (force-)update all references to the alias, and replace the
plain remove button with a confirmation dialog to handle dangling
references following the alias deletion.

StdRemoveButton cannot pass the extra 'dangling-references' parameter,
so the remove button is switched to a plain button that opens the
shared FirewallObjectRemove dialog.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/grid/FirewallAliases.js | 80 ++++++++++++++++++++--------
 1 file changed, 58 insertions(+), 22 deletions(-)

diff --git a/www/manager6/grid/FirewallAliases.js b/www/manager6/grid/FirewallAliases.js
index 06801d33..d4dacc7d 100644
--- a/www/manager6/grid/FirewallAliases.js
+++ b/www/manager6/grid/FirewallAliases.js
@@ -20,27 +20,43 @@ Ext.define('PVE.FirewallAliasEdit', {
             me.method = 'PUT';
         }
 
+        let items = [
+            {
+                xtype: 'textfield',
+                name: me.isCreate ? 'name' : 'rename',
+                fieldLabel: gettext('Name'),
+                allowBlank: false,
+            },
+            {
+                xtype: 'textfield',
+                name: 'cidr',
+                fieldLabel: gettext('IP/CIDR'),
+                allowBlank: false,
+            },
+            {
+                xtype: 'textfield',
+                name: 'comment',
+                fieldLabel: gettext('Comment'),
+            },
+        ];
+        if (!me.isCreate) {
+            items.push({
+                xtype: 'pveFirewallUpdateReferences',
+                noTip: gettext(
+                    'Do not update referencing rules and IPSets when renaming this alias. Note that this will render any reference to this alias invalid.',
+                ),
+                yesTip: gettext(
+                    'Update referencing rules and IPSets to point to the new alias name.',
+                ),
+                forceTip: gettext(
+                    'Update referencing rules and IPSets to point to the new alias name, overwriting any pre-existing alias with the target name. Can be used in case a failed rename left the cluster configuration in a partially-updated state.',
+                ),
+            });
+        }
+
         let ipanel = Ext.create('Proxmox.panel.InputPanel', {
             isCreate: me.isCreate,
-            items: [
-                {
-                    xtype: 'textfield',
-                    name: me.isCreate ? 'name' : 'rename',
-                    fieldLabel: gettext('Name'),
-                    allowBlank: false,
-                },
-                {
-                    xtype: 'textfield',
-                    name: 'cidr',
-                    fieldLabel: gettext('IP/CIDR'),
-                    allowBlank: false,
-                },
-                {
-                    xtype: 'textfield',
-                    name: 'comment',
-                    fieldLabel: gettext('Comment'),
-                },
-            ],
+            items,
         });
 
         Ext.apply(me, {
@@ -158,15 +174,35 @@ Ext.define('PVE.FirewallAliases', {
             },
         });
 
-        me.removeBtn = Ext.create('Proxmox.button.StdRemoveButton', {
+        me.removeBtn = Ext.create('Proxmox.button.Button', {
+            text: gettext('Remove'),
             disabled: true,
+            dangerous: true,
             selModel: sm,
             enableFn: (rec) =>
                 !!caps.vms['VM.Config.Network'] ||
                 !!caps.dc['Sys.Modify'] ||
                 !!caps.nodes['Sys.Modify'],
-            baseurl: me.base_url + '/',
-            callback: reload,
+            handler: function (btn, event, rec) {
+                Ext.create('PVE.window.FirewallObjectRemove', {
+                    item: { id: rec.data.name },
+                    url: me.base_url + '/' + rec.data.name,
+                    text: Ext.String.format(
+                        gettext("Are you sure you want to remove alias '{0}'"),
+                        rec.data.name,
+                    ),
+                    keepTip: gettext(
+                        'Keep referencing rules untouched. Some firewall configurations may end up with dangling references, which are dropped from the generated ruleset.',
+                    ),
+                    disableTip: gettext(
+                        'Disable all firewall rules referencing this alias. IPSet members referencing it are removed, as they cannot be disabled.',
+                    ),
+                    dropTip: gettext(
+                        'Delete all firewall rules and IPSet members referencing this alias.',
+                    ),
+                    apiCallDone: reload,
+                }).show();
+            },
         });
 
         Ext.apply(me, {
-- 
2.47.3