* [PATCH manager] fix #6113: ui: import: add pool selector
@ 2026-08-20 12:46 Elias Huhsovitz
2026-08-21 13:53 ` applied: " Dominik Csapak
0 siblings, 1 reply; 2+ messages in thread
From: Elias Huhsovitz @ 2026-08-20 12:46 UTC (permalink / raw)
To: pve-devel; +Cc: Elias Huhsovitz
There is no option to select a resource pool when importing a guest from
OVA or VMware/ESXi.
Add the pvePoolSelector to the guest import window.
Remove spacer to align rows.
Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
In GutestImport.js:2 there is this comment:
extend: 'Proxmox.window.Edit', // fixme: Proxmox.window.Edit?
Was it intended to extend 'PVE.window.Wizard' or
'PVE.qemu.CreateWizard' at some point?
This would unify the creation of qemu guests, since both the
GuestImport and the CreateWizard POST to the same API endpoint
(/nodes/{node}/qemu).
Since IMO the resource pool selector fits in neatly with the current
layout, I decided to simply extend it.
www/manager6/window/GuestImport.js | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 9c9b0f1b..1013fe14 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -369,6 +369,10 @@ Ext.define('PVE.window.GuestImport', {
let defaultBridge = values.defaultBridge;
delete values.defaultBridge;
+ if (!values.pool) {
+ delete values.pool;
+ }
+
let config = { ...view.vmConfig };
Ext.apply(config, values);
@@ -517,7 +521,13 @@ Ext.define('PVE.window.GuestImport', {
value: 512,
allowBlank: true,
},
- { xtype: 'displayfield' }, // spacer
+ {
+ xtype: 'pvePoolSelector',
+ fieldLabel: gettext('Resource Pool'),
+ name: 'pool',
+ value: '',
+ allowBlank: true,
+ },
{ xtype: 'displayfield' }, // spacer
{
xtype: 'pveDiskStorageSelector',
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* applied: [PATCH manager] fix #6113: ui: import: add pool selector
2026-08-20 12:46 [PATCH manager] fix #6113: ui: import: add pool selector Elias Huhsovitz
@ 2026-08-21 13:53 ` Dominik Csapak
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-08-21 13:53 UTC (permalink / raw)
To: pve-devel, e.huhsovitz
On Thu, 20 Aug 2026 14:46:01 +0200, Elias Huhsovitz wrote:
> There is no option to select a resource pool when importing a guest from
> OVA or VMware/ESXi.
>
> Add the pvePoolSelector to the guest import window.
>
> Remove spacer to align rows.
>
> [...]
Applied, thanks!
As for making the window into a wizard, I think this would be much more
work to integrate the logic of the import window into the wizard just
to have one component. So I'd leave them as is.
[1/1] fix #6113: ui: import: add pool selector
commit: 14a22df35955d97dfc1af21e117dc894a29df0c9
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-21 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-20 12:46 [PATCH manager] fix #6113: ui: import: add pool selector Elias Huhsovitz
2026-08-21 13:53 ` applied: " Dominik Csapak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.