all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH manager] fix #6113: ui: import: add pool selector
Date: Thu, 20 Aug 2026 14:46:01 +0200	[thread overview]
Message-ID: <20260820124601.135875-1-e.huhsovitz@proxmox.com> (raw)

There is no option to select a resource pool when importing a guest from
OVA or VMware/ESXi.

Add the pvePoolSelector to the guest import window.

Remove spacer to align rows.

Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
In GutestImport.js:2 there is this comment:

extend: 'Proxmox.window.Edit', // fixme: Proxmox.window.Edit?

Was it intended to extend 'PVE.window.Wizard' or
'PVE.qemu.CreateWizard' at some point?
This would unify the creation of qemu guests, since both the
GuestImport and the CreateWizard POST to the same API endpoint
(/nodes/{node}/qemu).

Since IMO the resource pool selector fits in neatly with the current
layout, I decided to simply extend it.

 www/manager6/window/GuestImport.js | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 9c9b0f1b..1013fe14 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -369,6 +369,10 @@ Ext.define('PVE.window.GuestImport', {
                         let defaultBridge = values.defaultBridge;
                         delete values.defaultBridge;
 
+                        if (!values.pool) {
+                            delete values.pool;
+                        }
+
                         let config = { ...view.vmConfig };
                         Ext.apply(config, values);
 
@@ -517,7 +521,13 @@ Ext.define('PVE.window.GuestImport', {
                             value: 512,
                             allowBlank: true,
                         },
-                        { xtype: 'displayfield' }, // spacer
+                        {
+                            xtype: 'pvePoolSelector',
+                            fieldLabel: gettext('Resource Pool'),
+                            name: 'pool',
+                            value: '',
+                            allowBlank: true,
+                        },
                         { xtype: 'displayfield' }, // spacer
                         {
                             xtype: 'pveDiskStorageSelector',
-- 
2.47.3





             reply	other threads:[~2026-08-20 12:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 12:46 Elias Huhsovitz [this message]
2026-08-21 13:53 ` applied: [PATCH manager] fix #6113: ui: import: add pool selector Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260820124601.135875-1-e.huhsovitz@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal