[PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls

[PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls

[Stefan Hanreich]

Some DELETE endpoints in the PVE API use additional parameters, that
are passed as a query string. The API client did not process any
parameters passed to delete calls, making it impossible to use DELETE
endpoints in the PVE API that rely on additional parameters (e.g. the
DELETE endpoint in the SDN IPAM IP module).

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/APIClient/LWP.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm
index d8472f7..216260a 100755
--- a/src/PVE/APIClient/LWP.pm
+++ b/src/PVE/APIClient/LWP.pm
@@ -332,6 +332,7 @@ sub call {
             );
 
         } elsif ($method eq 'DELETE') {
+            $uri->query_form($param);
             $response = $ua->request(HTTP::Request::Common::DELETE($uri));
         } else {
             raise("method $method not implemented\n");
-- 
2.47.3

Re: [PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls

[Hannes Laimer]

Thought this looked familiar :P

On 2026-08-13 12:52, Stefan Hanreich wrote:
> Some DELETE endpoints in the PVE API use additional parameters, that
> are passed as a query string. The API client did not process any
> parameters passed to delete calls, making it impossible to use DELETE
> endpoints in the PVE API that rely on additional parameters (e.g. the
> DELETE endpoint in the SDN IPAM IP module).
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/APIClient/LWP.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm
> index d8472f7..216260a 100755
> --- a/src/PVE/APIClient/LWP.pm
> +++ b/src/PVE/APIClient/LWP.pm
> @@ -332,6 +332,7 @@ sub call {
>              );
>  
>          } elsif ($method eq 'DELETE') {
> +            $uri->query_form($param);
>              $response = $ua->request(HTTP::Request::Common::DELETE($uri));
>          } else {
>              raise("method $method not implemented\n");

Re: [PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls

[Hannes Laimer]

On 2026-08-13 13:12, Hannes Laimer wrote:
> Thought this looked familiar :P
> 

sorry, forgot to paste the link

https://lore.proxmox.com/pve-devel/20260318132253.177837-1-h.laimer@proxmox.com/

> On 2026-08-13 12:52, Stefan Hanreich wrote:
>> Some DELETE endpoints in the PVE API use additional parameters, that
>> are passed as a query string. The API client did not process any
>> parameters passed to delete calls, making it impossible to use DELETE
>> endpoints in the PVE API that rely on additional parameters (e.g. the
>> DELETE endpoint in the SDN IPAM IP module).
>>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
>>  src/PVE/APIClient/LWP.pm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm
>> index d8472f7..216260a 100755
>> --- a/src/PVE/APIClient/LWP.pm
>> +++ b/src/PVE/APIClient/LWP.pm
>> @@ -332,6 +332,7 @@ sub call {
>>              );
>>  
>>          } elsif ($method eq 'DELETE') {
>> +            $uri->query_form($param);
>>              $response = $ua->request(HTTP::Request::Common::DELETE($uri));
>>          } else {
>>              raise("method $method not implemented\n");
> 
> 
> 
> 
>