all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls
Date: Thu, 13 Aug 2026 13:13:02 +0200	[thread overview]
Message-ID: <354b35e7-01e8-4d5f-8177-f48044d1268e@proxmox.com> (raw)
In-Reply-To: <20260813105200.139383-1-s.hanreich@proxmox.com>

Thought this looked familiar :P

On 2026-08-13 12:52, Stefan Hanreich wrote:
> Some DELETE endpoints in the PVE API use additional parameters, that
> are passed as a query string. The API client did not process any
> parameters passed to delete calls, making it impossible to use DELETE
> endpoints in the PVE API that rely on additional parameters (e.g. the
> DELETE endpoint in the SDN IPAM IP module).
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/APIClient/LWP.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm
> index d8472f7..216260a 100755
> --- a/src/PVE/APIClient/LWP.pm
> +++ b/src/PVE/APIClient/LWP.pm
> @@ -332,6 +332,7 @@ sub call {
>              );
>  
>          } elsif ($method eq 'DELETE') {
> +            $uri->query_form($param);
>              $response = $ua->request(HTTP::Request::Common::DELETE($uri));
>          } else {
>              raise("method $method not implemented\n");





  reply	other threads:[~2026-08-13 11:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 10:51 [PATCH pve-apiclient 1/1] client: allow passing query parameters to delete calls Stefan Hanreich
2026-08-13 11:13 ` Hannes Laimer [this message]
2026-08-13 11:13   ` Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=354b35e7-01e8-4d5f-8177-f48044d1268e@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal