all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 2/3] ui: s3: shorten label to better render request rate limit
Date: Tue,  4 Aug 2026 13:29:36 +0200	[thread overview]
Message-ID: <20260804112937.358002-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260804112937.358002-1-c.ebner@proxmox.com>

Given the limited space, the long labels wrap around and introduce
paddings, leading to misalignments and inconsistencies with the rest
of the edit window components.

Instead of showing the exact methods limited in the label, shorten it
by only menioning active/passive request method and move the more
descriptive information to a qtip.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/window/S3ClientEdit.js | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
index 003a8abbc..5937ce8e7 100644
--- a/www/window/S3ClientEdit.js
+++ b/www/window/S3ClientEdit.js
@@ -138,7 +138,13 @@ Ext.define('PBS.window.S3ClientEdit', {
             {
                 xtype: 'pbsRateLimitField',
                 name: 'limit-active-requests',
-                fieldLabel: gettext('PUT/POST/DELETE request limit (#/s)'),
+                fieldLabel: gettext('Active Methods'),
+                autoEl: {
+                    tag: 'div',
+                    'data-qtip': gettext(
+                        'Shared request rate limit for active methods (PUT/POST/DELETE)',
+                    ),
+                },
             },
             {
                 xtype: 'proxmoxcheckbox',
@@ -172,7 +178,13 @@ Ext.define('PBS.window.S3ClientEdit', {
             {
                 xtype: 'pbsRateLimitField',
                 name: 'limit-passive-requests',
-                fieldLabel: gettext('GET/HEAD request limit (#/s)'),
+                fieldLabel: gettext('Passive Methods'),
+                autoEl: {
+                    tag: 'div',
+                    'data-qtip': gettext(
+                        'Shared request rate limit for passive methods (GET/HEAD)',
+                    ),
+                },
             },
         ],
         advancedColumnB: [
-- 
2.47.3





  parent reply	other threads:[~2026-08-04 11:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 11:29 [PATCH proxmox-backup 0/3] S3 endpoint ui fixups Christian Ebner
2026-08-04 11:29 ` [PATCH proxmox-backup 1/3] www: add rate limit field for request limits Christian Ebner
2026-08-04 11:29 ` Christian Ebner [this message]
2026-08-04 11:29 ` [PATCH proxmox-backup 3/3] ui: s3: fix title and border rendering for provider quirks Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804112937.358002-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal