all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 3/3] ui: s3: fix title and border rendering for provider quirks
Date: Tue,  4 Aug 2026 13:29:37 +0200	[thread overview]
Message-ID: <20260804112937.358002-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260804112937.358002-1-c.ebner@proxmox.com>

The title was not rendered since declared incorrectly as fieldLabel
and the border surrounding the fieldset overflowed. Fix by declaring
the title correctly and force a margin on the fieldset, so it aligns
with the other items.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/window/S3ClientEdit.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
index 5937ce8e7..73a46ba86 100644
--- a/www/window/S3ClientEdit.js
+++ b/www/window/S3ClientEdit.js
@@ -191,7 +191,8 @@ Ext.define('PBS.window.S3ClientEdit', {
             {
                 xtype: 'fieldset',
                 name: 'provider-quirks',
-                fieldLabel: gettext('Provider Quirks'),
+                title: gettext('Provider Quirks'),
+                margin: '0 3 0 0',
                 items: [
                     {
                         xtype: 'checkbox',
-- 
2.47.3





      parent reply	other threads:[~2026-08-04 11:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 11:29 [PATCH proxmox-backup 0/3] S3 endpoint ui fixups Christian Ebner
2026-08-04 11:29 ` [PATCH proxmox-backup 1/3] www: add rate limit field for request limits Christian Ebner
2026-08-04 11:29 ` [PATCH proxmox-backup 2/3] ui: s3: shorten label to better render request rate limit Christian Ebner
2026-08-04 11:29 ` Christian Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804112937.358002-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal