From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 08F1C1FF0E3 for ; Tue, 04 Aug 2026 13:29:56 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D6D4321705; Tue, 04 Aug 2026 13:29:54 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 2/3] ui: s3: shorten label to better render request rate limit Date: Tue, 4 Aug 2026 13:29:36 +0200 Message-ID: <20260804112937.358002-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260804112937.358002-1-c.ebner@proxmox.com> References: <20260804112937.358002-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785842978964 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.122 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CEYWSSDZFRLSOVBW2GMGPWDJ2V6M7PMC X-Message-ID-Hash: CEYWSSDZFRLSOVBW2GMGPWDJ2V6M7PMC X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Given the limited space, the long labels wrap around and introduce paddings, leading to misalignments and inconsistencies with the rest of the edit window components. Instead of showing the exact methods limited in the label, shorten it by only menioning active/passive request method and move the more descriptive information to a qtip. Signed-off-by: Christian Ebner --- www/window/S3ClientEdit.js | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js index 003a8abbc..5937ce8e7 100644 --- a/www/window/S3ClientEdit.js +++ b/www/window/S3ClientEdit.js @@ -138,7 +138,13 @@ Ext.define('PBS.window.S3ClientEdit', { { xtype: 'pbsRateLimitField', name: 'limit-active-requests', - fieldLabel: gettext('PUT/POST/DELETE request limit (#/s)'), + fieldLabel: gettext('Active Methods'), + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Shared request rate limit for active methods (PUT/POST/DELETE)', + ), + }, }, { xtype: 'proxmoxcheckbox', @@ -172,7 +178,13 @@ Ext.define('PBS.window.S3ClientEdit', { { xtype: 'pbsRateLimitField', name: 'limit-passive-requests', - fieldLabel: gettext('GET/HEAD request limit (#/s)'), + fieldLabel: gettext('Passive Methods'), + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Shared request rate limit for passive methods (GET/HEAD)', + ), + }, }, ], advancedColumnB: [ -- 2.47.3