all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox] pbs-api-types: reword outdated maintenance type docstrings
@ 2026-07-22 10:17 Christian Ebner
  0 siblings, 0 replies; only message in thread
From: Christian Ebner @ 2026-07-22 10:17 UTC (permalink / raw)
  To: pbs-devel

There are now more maintenance types than 'read-only' and 'offline'.

Since listing them all is not really feasible anymore, do not
explicitley mention the type variants in the docstring.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Note:
This patch is intended as followup to
https://lore.proxmox.com/pbs-devel/20260702145916.360488-1-r.obkircher@proxmox.com/

 pbs-api-types/src/datastore.rs   | 2 +-
 pbs-api-types/src/maintenance.rs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index ccb7c748..b173c7f0 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -554,7 +554,7 @@ pub struct DataStoreConfig {
     #[serde(skip_serializing_if = "Option::is_none")]
     pub tuning: Option<String>,
 
-    /// Maintenance mode, type is either 'offline' or 'read-only', message should be enclosed in "
+    /// Maintenance mode, message should be enclosed in "
     #[serde(skip_serializing_if = "Option::is_none")]
     pub maintenance_mode: Option<String>,
 
diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs
index 9469ed8b..99dffbee 100644
--- a/pbs-api-types/src/maintenance.rs
+++ b/pbs-api-types/src/maintenance.rs
@@ -77,7 +77,7 @@ serde_plain::derive_fromstr_from_deserialize!(MaintenanceType);
 #[derive(Deserialize, Serialize)]
 /// Maintenance mode
 pub struct MaintenanceMode {
-    /// Type of maintenance ("read-only" or "offline").
+    /// Type of maintenance.
     #[serde(rename = "type")]
     pub ty: MaintenanceType,
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-07-22 10:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-22 10:17 [PATCH proxmox] pbs-api-types: reword outdated maintenance type docstrings Christian Ebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal