all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox] pbs-api-types: reword outdated maintenance type docstrings
Date: Wed, 22 Jul 2026 12:17:20 +0200	[thread overview]
Message-ID: <20260722101720.141156-1-c.ebner@proxmox.com> (raw)

There are now more maintenance types than 'read-only' and 'offline'.

Since listing them all is not really feasible anymore, do not
explicitley mention the type variants in the docstring.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Note:
This patch is intended as followup to
https://lore.proxmox.com/pbs-devel/20260702145916.360488-1-r.obkircher@proxmox.com/

 pbs-api-types/src/datastore.rs   | 2 +-
 pbs-api-types/src/maintenance.rs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index ccb7c748..b173c7f0 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -554,7 +554,7 @@ pub struct DataStoreConfig {
     #[serde(skip_serializing_if = "Option::is_none")]
     pub tuning: Option<String>,
 
-    /// Maintenance mode, type is either 'offline' or 'read-only', message should be enclosed in "
+    /// Maintenance mode, message should be enclosed in "
     #[serde(skip_serializing_if = "Option::is_none")]
     pub maintenance_mode: Option<String>,
 
diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs
index 9469ed8b..99dffbee 100644
--- a/pbs-api-types/src/maintenance.rs
+++ b/pbs-api-types/src/maintenance.rs
@@ -77,7 +77,7 @@ serde_plain::derive_fromstr_from_deserialize!(MaintenanceType);
 #[derive(Deserialize, Serialize)]
 /// Maintenance mode
 pub struct MaintenanceMode {
-    /// Type of maintenance ("read-only" or "offline").
+    /// Type of maintenance.
     #[serde(rename = "type")]
     pub ty: MaintenanceType,
 
-- 
2.47.3





                 reply	other threads:[~2026-07-22 10:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722101720.141156-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal