From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH manager v3 0/2] ui: fabrics: handle unsupported IP properties for BGP interfaces
Date: Wed, 15 Jul 2026 10:15:14 +0200 [thread overview]
Message-ID: <20260715081519.29721-1-l.sichert@proxmox.com> (raw)
BGP unnumbered interfaces do not support per-interface IPv4 or IPv6
addresses. The UI already hid the IPv6 column through a declarative
support flag, but IPv4 needed a protocol-specific initComponent()
override that manually filtered the base column list.
This series first adjusts the IPv4 column handling to make it optional
via a declarative support flag. It then uses the IPv4/IPv6 support flags
to avoid sending unsupported ip/ip6 interface data to the backend.
Note:
The Reviewed-by and Tested-by trailers from Hannes were originally
sent for the v2 [1], but I kept them for this series as well, as the
code did not change.
[1]: https://lore.proxmox.com/all/20260603155521.125175-1-l.sichert@proxmox.com/
Changes from v2 to v3(thanks @Dominik):
- split up the code into two commits
Changes from v1 to v2(thanks @Hannes):
- make ipv4 column optional via support flag
manager:
Lukas Sichert (2):
ui: fabrics: make IPv4 interface column optional
ui: fabrics: skip unsupported IP properties on submit
www/manager6/sdn/fabrics/InterfacePanel.js | 36 +++++++++++--------
.../sdn/fabrics/bgp/InterfacePanel.js | 11 +-----
2 files changed, 23 insertions(+), 24 deletions(-)
Summary over all repositories:
2 files changed, 23 insertions(+), 24 deletions(-)
--
Generated by murpp 0.12.0
next reply other threads:[~2026-07-15 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 8:15 Lukas Sichert [this message]
2026-07-15 8:15 ` [PATCH manager v3 1/2] ui: fabrics: make IPv4 interface column optional Lukas Sichert
2026-07-15 8:15 ` [PATCH manager v3 2/2] ui: fabrics: skip unsupported IP properties on submit Lukas Sichert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715081519.29721-1-l.sichert@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.