[PATCH manager v3 1/2] ui: fabrics: make IPv4 interface column optional

[Lukas Sichert <l.sichert@proxmox.com>]

The base interface panel keeps the IPv4 column in commonColumns, while
IPv6 is added conditionally through hasIpv6Support. BGP unnumbered
interfaces therefore have to override initComponent() and filter that base
column out manually.

Move the IPv4 column into the same conditional column-building path as
IPv6 and add a matching hasIpv4Support flag. Keep IPv4 support enabled
by default so existing panels inherit the previous behavior unless they
explicitly opt out. Then disable BGP IPv4 support declaratively by
setting that flag to false.

Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
Tested-by: Hannes Laimer <h.laimer@proxmox.com>
Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/manager6/sdn/fabrics/InterfacePanel.js    | 30 +++++++++++--------
 .../sdn/fabrics/bgp/InterfacePanel.js         | 11 +------
 2 files changed, 18 insertions(+), 23 deletions(-)

diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
index f07e7859..95424bc0 100644
--- a/www/manager6/sdn/fabrics/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/InterfacePanel.js
@@ -6,6 +6,7 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
 
     nodeInterfaces: {},
 
+    hasIpv4Support: true,
     hasIpv6Support: true,
 
     selModel: {
@@ -59,19 +60,6 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
             dataIndex: 'type',
             flex: 1,
         },
-        {
-            text: gettext('IPv4'),
-            xtype: 'widgetcolumn',
-            dataIndex: 'ip',
-            flex: 1,
-            widget: {
-                xtype: 'proxmoxtextfield',
-                isFormField: false,
-                bind: {
-                    disabled: '{record.isDisabled}',
-                },
-            },
-        },
     ],
 
     additionalColumns: [],
@@ -112,6 +100,22 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
 
         let columns = [...me.commonColumns];
 
+        if (me.hasIpv4Support) {
+            columns.push({
+                text: gettext('IPv4'),
+                xtype: 'widgetcolumn',
+                dataIndex: 'ip',
+                flex: 1,
+                widget: {
+                    xtype: 'proxmoxtextfield',
+                    isFormField: false,
+                    bind: {
+                        disabled: '{record.isDisabled}',
+                    },
+                },
+            });
+        }
+
         if (me.hasIpv6Support) {
             columns.push({
                 text: gettext('IPv6'),
diff --git a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
index c7ac7627..fd5e6f4b 100644
--- a/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/bgp/InterfacePanel.js
@@ -1,15 +1,6 @@
 Ext.define('PVE.sdn.Fabric.Bgp.InterfacePanel', {
     extend: 'PVE.sdn.Fabric.InterfacePanel',
 
+    hasIpv4Support: false,
     hasIpv6Support: false,
-
-    // BGP unnumbered interfaces have no IP - override commonColumns to
-    // exclude the IP column that the base class defines.
-    initComponent: function () {
-        let me = this;
-
-        me.commonColumns = me.commonColumns.filter((col) => col.dataIndex !== 'ip');
-
-        me.callParent();
-    },
 });
-- 
2.47.3