From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AD6221FF0E5 for ; Wed, 15 Jul 2026 10:15:30 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B69E221429; Wed, 15 Jul 2026 10:15:28 +0200 (CEST) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3 0/2] ui: fabrics: handle unsupported IP properties for BGP interfaces Date: Wed, 15 Jul 2026 10:15:14 +0200 Message-ID: <20260715081519.29721-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784103306556 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.185 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JMGJ7UXJ62RBP36M6SAJQMDR7VNSXUBD X-Message-ID-Hash: JMGJ7UXJ62RBP36M6SAJQMDR7VNSXUBD X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: BGP unnumbered interfaces do not support per-interface IPv4 or IPv6 addresses. The UI already hid the IPv6 column through a declarative support flag, but IPv4 needed a protocol-specific initComponent() override that manually filtered the base column list. This series first adjusts the IPv4 column handling to make it optional via a declarative support flag. It then uses the IPv4/IPv6 support flags to avoid sending unsupported ip/ip6 interface data to the backend. Note: The Reviewed-by and Tested-by trailers from Hannes were originally sent for the v2 [1], but I kept them for this series as well, as the code did not change. [1]: https://lore.proxmox.com/all/20260603155521.125175-1-l.sichert@proxmox.com/ Changes from v2 to v3(thanks @Dominik): - split up the code into two commits Changes from v1 to v2(thanks @Hannes): - make ipv4 column optional via support flag manager: Lukas Sichert (2): ui: fabrics: make IPv4 interface column optional ui: fabrics: skip unsupported IP properties on submit www/manager6/sdn/fabrics/InterfacePanel.js | 36 +++++++++++-------- .../sdn/fabrics/bgp/InterfacePanel.js | 11 +----- 2 files changed, 23 insertions(+), 24 deletions(-) Summary over all repositories: 2 files changed, 23 insertions(+), 24 deletions(-) -- Generated by murpp 0.12.0