all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ui: utils: fix qemu version check to unbreak USB port limit
Date: Mon,  1 Jun 2026 11:12:13 +0200	[thread overview]
Message-ID: <20260601091328.66757-1-f.ebner@proxmox.com> (raw)

The qemu_min_version() helper is only used for the USB port limit
right now. The implementation was wrong, as it wrongly required the
minor version (or micro version if there were such a caller) to be
greater or equal too, even if the major version is already greater.

Reported by a user in the forum:
[0]: https://forum.proxmox.com/threads/26551/post-855326

Fixes: 17dcba38 ("ui: qemu: increase available usb ports depending on machine and ostype")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/Utils.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 2ed4e65d..bbf59d8f 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1808,6 +1808,9 @@ Ext.define('PVE.Utils', {
         qemu_min_version: function (toCheck, minVersion) {
             let i;
             for (i = 0; i < toCheck.length && i < minVersion.length; i++) {
+                if (toCheck[i] > minVersion[i]) {
+                    return true;
+                }
                 if (toCheck[i] < minVersion[i]) {
                     return false;
                 }
-- 
2.47.3





             reply	other threads:[~2026-06-01  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  9:12 Fiona Ebner [this message]
2026-06-01 13:14 ` applied: [PATCH manager] ui: utils: fix qemu version check to unbreak USB port limit Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601091328.66757-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal