From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1A5DE1FF138 for ; Mon, 01 Jun 2026 11:14:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24FE615F4D; Mon, 1 Jun 2026 11:14:07 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH manager] ui: utils: fix qemu version check to unbreak USB port limit Date: Mon, 1 Jun 2026 11:12:13 +0200 Message-ID: <20260601091328.66757-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780305178027 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record T_SPF_PERMERROR 0.01 SPF: test of record failed (permerror) Message-ID-Hash: LHJTII7WIAP3QCEQYBFLI4FN34AK2APS X-Message-ID-Hash: LHJTII7WIAP3QCEQYBFLI4FN34AK2APS X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The qemu_min_version() helper is only used for the USB port limit right now. The implementation was wrong, as it wrongly required the minor version (or micro version if there were such a caller) to be greater or equal too, even if the major version is already greater. Reported by a user in the forum: [0]: https://forum.proxmox.com/threads/26551/post-855326 Fixes: 17dcba38 ("ui: qemu: increase available usb ports depending on machine and ostype") Signed-off-by: Fiona Ebner --- www/manager6/Utils.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 2ed4e65d..bbf59d8f 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1808,6 +1808,9 @@ Ext.define('PVE.Utils', { qemu_min_version: function (toCheck, minVersion) { let i; for (i = 0; i < toCheck.length && i < minVersion.length; i++) { + if (toCheck[i] > minVersion[i]) { + return true; + } if (toCheck[i] < minVersion[i]) { return false; } -- 2.47.3