From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: [PATCH manager] ui: utils: fix qemu version check to unbreak USB port limit
Date: Mon, 1 Jun 2026 15:14:16 +0200 [thread overview]
Message-ID: <178031953949.2815883.7722858864032945907.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260601091328.66757-1-f.ebner@proxmox.com>
On Mon, 01 Jun 2026 11:12:13 +0200, Fiona Ebner wrote:
> The qemu_min_version() helper is only used for the USB port limit
> right now. The implementation was wrong, as it wrongly required the
> minor version (or micro version if there were such a caller) to be
> greater or equal too, even if the major version is already greater.
>
> Reported by a user in the forum:
> [0]: https://forum.proxmox.com/threads/26551/post-855326
>
> [...]
Applied, thanks!
Ironically, not even the example in the comment worked, mea culpa for that.
I wish we would have some kind of regression test system for our javascript
helpers (renderer, formatter, things like this...)
[1/1] ui: utils: fix qemu version check to unbreak USB port limit
commit: 3185d429ca30bfffff4f95befeae36f67a531a5f
prev parent reply other threads:[~2026-06-01 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 9:12 [PATCH manager] ui: utils: fix qemu version check to unbreak USB port limit Fiona Ebner
2026-06-01 13:14 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178031953949.2815883.7722858864032945907.b4-ty@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.