* [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers
@ 2026-05-07 11:23 Daniel Herzig
2026-05-08 11:30 ` Gabriel Goller
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Herzig @ 2026-05-07 11:23 UTC (permalink / raw)
To: pve-devel
This patch addresses the incorrect application of the original
vmid to cloned containers in pve ipams, which results in duplicate
vmid entries in the `/cluster/sdn/ipams/pve/status` endpoint.
Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
THX @Gabriel for the offline input.
src/PVE/API2/LXC.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 838dd76..89d8a53 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
@@ -2235,7 +2235,7 @@ __PACKAGE__->register_method({
my $rootdir = PVE::LXC::mount_all($newid, $storecfg, $conf, 1);
eval {
- PVE::LXC::create_ifaces_ipams_ips($conf, $vmid);
+ PVE::LXC::create_ifaces_ipams_ips($conf, $newid);
my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir);
$lxc_setup->post_clone_hook($conf);
};
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers
2026-05-07 11:23 [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers Daniel Herzig
@ 2026-05-08 11:30 ` Gabriel Goller
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Goller @ 2026-05-08 11:30 UTC (permalink / raw)
To: Daniel Herzig; +Cc: pve-devel
On 07.05.2026 13:23, Daniel Herzig wrote:
> This patch addresses the incorrect application of the original
> vmid to cloned containers in pve ipams, which results in duplicate
> vmid entries in the `/cluster/sdn/ipams/pve/status` endpoint.
>
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
LGTM, Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> THX @Gabriel for the offline input.
>
> src/PVE/API2/LXC.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index 838dd76..89d8a53 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -2235,7 +2235,7 @@ __PACKAGE__->register_method({
> my $rootdir = PVE::LXC::mount_all($newid, $storecfg, $conf, 1);
>
> eval {
> - PVE::LXC::create_ifaces_ipams_ips($conf, $vmid);
> + PVE::LXC::create_ifaces_ipams_ips($conf, $newid);
> my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir);
> $lxc_setup->post_clone_hook($conf);
> };
> --
> 2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-08 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07 11:23 [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers Daniel Herzig
2026-05-08 11:30 ` Gabriel Goller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.