From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D26231FF17A for ; Fri, 08 May 2026 13:31:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ECD62158B8; Fri, 8 May 2026 13:31:23 +0200 (CEST) Date: Fri, 8 May 2026 13:30:46 +0200 From: Gabriel Goller To: Daniel Herzig Subject: Re: [PATCH container] fix #7568: ensure new vmid in pve ipams when cloning containers Message-ID: Mail-Followup-To: Daniel Herzig , pve-devel@lists.proxmox.com References: <20260507112341.268585-1-d.herzig@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260507112341.268585-1-d.herzig@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778239737718 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SEPIQFICC73XCN7EV7AKI73ZGLQCWMVH X-Message-ID-Hash: SEPIQFICC73XCN7EV7AKI73ZGLQCWMVH X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 07.05.2026 13:23, Daniel Herzig wrote: > This patch addresses the incorrect application of the original > vmid to cloned containers in pve ipams, which results in duplicate > vmid entries in the `/cluster/sdn/ipams/pve/status` endpoint. > > Signed-off-by: Daniel Herzig LGTM, Consider: Reviewed-by: Gabriel Goller > --- > THX @Gabriel for the offline input. > > src/PVE/API2/LXC.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm > index 838dd76..89d8a53 100644 > --- a/src/PVE/API2/LXC.pm > +++ b/src/PVE/API2/LXC.pm > @@ -2235,7 +2235,7 @@ __PACKAGE__->register_method({ > my $rootdir = PVE::LXC::mount_all($newid, $storecfg, $conf, 1); > > eval { > - PVE::LXC::create_ifaces_ipams_ips($conf, $vmid); > + PVE::LXC::create_ifaces_ipams_ips($conf, $newid); > my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir); > $lxc_setup->post_clone_hook($conf); > }; > -- > 2.47.3