[PATCH pve-manager 0/1] Fix typo in comment

[PATCH pve-manager 0/1] Fix typo in comment

[Erik Fastermann]

Erik Fastermann (1):
  ui: fix typo in comment

 www/manager6/dc/PCIMapView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.47.3

[PATCH pve-manager 1/1] ui: fix typo in comment

[Erik Fastermann]

Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
 www/manager6/dc/PCIMapView.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/dc/PCIMapView.js b/www/manager6/dc/PCIMapView.js
index 6ea23a45..969ad2ea 100644
--- a/www/manager6/dc/PCIMapView.js
+++ b/www/manager6/dc/PCIMapView.js
@@ -20,7 +20,7 @@ Ext.define('PVE.dc.PCIMapView', {
         data.forEach((entry) => {
             ids[entry.id] = entry;
         });
-        // extract the mdev property from the global entry and insert to the individiual entries,
+        // extract the mdev property from the global entry and insert to the individual entries,
         // so we can reuse the normal checking logic
         let mdev;
         me.getRootNode()?.cascade(function (rec) {
-- 
2.47.3

Re: [PATCH pve-manager 1/1] ui: fix typo in comment

[Fiona Ebner]

The commit title could include a second prefix like 'pci map:' then it's
clearer where the typo was fixed.

Note that it's preferred to avoid sending a cover letter when it's only
a stand-alone patch. In rare cases, it can be fine, if the cover letter
includes additional information that cannot easily be included in the
patch itself (e.g. long test output), but most often such extra
information can also be added below the three dashes if it should not
land in git history.

Am 24.04.26 um 9:24 AM schrieb Erik Fastermann:
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
>  www/manager6/dc/PCIMapView.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/dc/PCIMapView.js b/www/manager6/dc/PCIMapView.js
> index 6ea23a45..969ad2ea 100644
> --- a/www/manager6/dc/PCIMapView.js
> +++ b/www/manager6/dc/PCIMapView.js
> @@ -20,7 +20,7 @@ Ext.define('PVE.dc.PCIMapView', {
>          data.forEach((entry) => {
>              ids[entry.id] = entry;
>          });
> -        // extract the mdev property from the global entry and insert to the individiual entries,
> +        // extract the mdev property from the global entry and insert to the individual entries,

Pre-existing, but the sentence still sounds a bit off to me. Maybe we
can use "and add it to the..." or "and set it for the..." instead?

>          // so we can reuse the normal checking logic
>          let mdev;
>          me.getRootNode()?.cascade(function (rec) {