From: Fiona Ebner <f.ebner@proxmox.com>
To: Erik Fastermann <e.fastermann@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager 1/1] ui: fix typo in comment
Date: Mon, 27 Apr 2026 15:44:52 +0200 [thread overview]
Message-ID: <b8b99f6b-e953-4e00-ba02-4c338c15dbb3@proxmox.com> (raw)
In-Reply-To: <20260422093634.71367-2-e.fastermann@proxmox.com>
The commit title could include a second prefix like 'pci map:' then it's
clearer where the typo was fixed.
Note that it's preferred to avoid sending a cover letter when it's only
a stand-alone patch. In rare cases, it can be fine, if the cover letter
includes additional information that cannot easily be included in the
patch itself (e.g. long test output), but most often such extra
information can also be added below the three dashes if it should not
land in git history.
Am 24.04.26 um 9:24 AM schrieb Erik Fastermann:
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
> www/manager6/dc/PCIMapView.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/dc/PCIMapView.js b/www/manager6/dc/PCIMapView.js
> index 6ea23a45..969ad2ea 100644
> --- a/www/manager6/dc/PCIMapView.js
> +++ b/www/manager6/dc/PCIMapView.js
> @@ -20,7 +20,7 @@ Ext.define('PVE.dc.PCIMapView', {
> data.forEach((entry) => {
> ids[entry.id] = entry;
> });
> - // extract the mdev property from the global entry and insert to the individiual entries,
> + // extract the mdev property from the global entry and insert to the individual entries,
Pre-existing, but the sentence still sounds a bit off to me. Maybe we
can use "and add it to the..." or "and set it for the..." instead?
> // so we can reuse the normal checking logic
> let mdev;
> me.getRootNode()?.cascade(function (rec) {
prev parent reply other threads:[~2026-04-27 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 9:36 [PATCH pve-manager 0/1] Fix typo in comment Erik Fastermann
2026-04-22 9:36 ` [PATCH pve-manager 1/1] ui: fix " Erik Fastermann
2026-04-27 13:44 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8b99f6b-e953-4e00-ba02-4c338c15dbb3@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=e.fastermann@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.