[PATCH manager v3] ui: ha: add disarm/re-arm button

[PATCH manager v3] ui: ha: add disarm/re-arm button

[Dominik Rusovac]

The button to disarm HA in either of the resource modes ('freeze' or
'ignore') is disabled as long as HA is disarmed. Analogously, the button
to arm HA is disabled as long as HA is not disarmed.

For feedback, after clicking either of the buttons, icon spins as long as
(dis)arming process has not changed the armed-state of HA.

The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA"
and "Arm HA" are complements. There may be more suitable pairs of icons
though.

Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
changes since v2:
* inline setting isDisarmed flag
* use 'tbar'
* switch positions of buttons
* hook into 'hastatuschange' to provide feedback via spinning icon while
  armed-state of HA changes:
  - add 'isDisarmedPendingState' to controller 
  - on successful (dis)arm request, store expected 'isDisarmed'-value 
    in 'isDisarmedPendingState' 
  - match 'isDisarmedPendingState' on 'isDisarmed' in 'hastatuschange' 
    and clear 'isDisarmedPendingState'

 www/manager6/ha/Status.js     | 113 ++++++++++++++++++++++++++++++++++
 www/manager6/ha/StatusView.js |   8 +++
 2 files changed, 121 insertions(+)

diff --git a/www/manager6/ha/Status.js b/www/manager6/ha/Status.js
index b0b0feb9..42b498ef 100644
--- a/www/manager6/ha/Status.js
+++ b/www/manager6/ha/Status.js
@@ -8,6 +8,102 @@ Ext.define('PVE.ha.Status', {
         align: 'stretch',
     },
 
+    viewModel: {
+        data: {
+            haDisarmed: false,
+        },
+    },
+
+    controller: {
+        xclass: 'Ext.app.ViewController',
+
+        isDisarmedPendingState: null,
+
+        handleDisarmButton: function (menuItem) {
+            let me = this;
+            let view = me.getView();
+
+            Ext.Msg.confirm(
+                gettext('Confirm'),
+                Ext.String.format(
+                    gettext("Are you sure you want to disarm HA with resource mode '{0}'?"),
+                    menuItem.text,
+                ),
+                function (btn) {
+                    if (btn !== 'yes') {
+                        return;
+                    }
+                    Proxmox.Utils.API2Request({
+                        url: '/cluster/ha/status/disarm-ha',
+                        params: { 'resource-mode': menuItem.mode },
+                        method: 'POST',
+                        success: function () {
+                            me.isDisarmedPendingState = true;
+                            view.mask(gettext('Disarming HA...'));
+                        },
+                        failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+                    });
+                },
+            );
+        },
+
+        handleArmButton: function () {
+            let me = this;
+            let view = me.getView();
+
+            Ext.Msg.confirm(
+                gettext('Confirm'),
+                gettext('Are you sure you want to arm HA?'),
+                function (btn) {
+                    if (btn !== 'yes') {
+                        return;
+                    }
+                    Proxmox.Utils.API2Request({
+                        url: '/cluster/ha/status/arm-ha',
+                        method: 'POST',
+                        success: function () {
+                            me.isDisarmedPendingState = false;
+                            view.mask(gettext('Arming HA...'));
+                        },
+                        failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+                    });
+                },
+            );
+        },
+    },
+
+    tbar: [
+        {
+            text: gettext('Arm HA'),
+            iconCls: 'fa fa-link',
+            bind: {
+                disabled: '{!haDisarmed}',
+            },
+            handler: 'handleArmButton',
+        },
+        {
+            text: gettext('Disarm HA'),
+            iconCls: 'fa fa-unlink',
+            bind: {
+                disabled: '{haDisarmed}',
+            },
+            menu: [
+                {
+                    text: gettext('Freeze'),
+                    iconCls: 'fa fa-snowflake-o',
+                    mode: 'freeze',
+                    handler: 'handleDisarmButton',
+                },
+                {
+                    text: gettext('Ignore'),
+                    iconCls: 'fa fa-eye-slash',
+                    mode: 'ignore',
+                    handler: 'handleDisarmButton',
+                },
+            ],
+        },
+    ],
+
     initComponent: function () {
         var me = this;
 
@@ -30,6 +126,23 @@ Ext.define('PVE.ha.Status', {
                 border: 0,
                 collapsible: true,
                 padding: '0 0 20 0',
+                listeners: {
+                    hastatuschange: function (isDisarmed) {
+                        let vm = me.getViewModel();
+                        let controller = me.getController();
+
+                        vm.set('haDisarmed', isDisarmed);
+
+                        if (controller.isDisarmedPendingState === null) {
+                            return;
+                        }
+
+                        if (isDisarmed === controller.isDisarmedPendingState) {
+                            me.unmask();
+                            controller.isDisarmedPendingState = null;
+                        }
+                    },
+                },
             },
             {
                 xtype: 'pveHAResourcesView',
diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
index bc2da71f..4cbe85a1 100644
--- a/www/manager6/ha/StatusView.js
+++ b/www/manager6/ha/StatusView.js
@@ -42,6 +42,13 @@ Ext.define(
                 },
             });
 
+            me.rstore.on('load', function () {
+                let fencing = store.findRecord('type', 'fencing');
+                let disarmed = fencing && fencing.get('armed-state') === 'disarmed';
+
+                me.fireEvent('hastatuschange', disarmed);
+            });
+
             Ext.apply(me, {
                 store: store,
                 stateful: false,
@@ -105,6 +112,7 @@ Ext.define(
                         return PVE.data.ResourceStore.guestName(vmid);
                     },
                 },
+                'armed-state',
             ],
             idProperty: 'id',
         });
-- 
2.47.3