From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EF84F1FF13C for ; Thu, 16 Apr 2026 13:20:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A30D2C52; Thu, 16 Apr 2026 13:20:43 +0200 (CEST) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3] ui: ha: add disarm/re-arm button Date: Thu, 16 Apr 2026 13:20:33 +0200 Message-ID: <20260416112033.148589-1-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776338359384 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.468 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3V6UIXIMAQTWW5IY7I4GQ4XLOFWW5R5V X-Message-ID-Hash: 3V6UIXIMAQTWW5IY7I4GQ4XLOFWW5R5V X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The button to disarm HA in either of the resource modes ('freeze' or 'ignore') is disabled as long as HA is disarmed. Analogously, the button to arm HA is disabled as long as HA is not disarmed. For feedback, after clicking either of the buttons, icon spins as long as (dis)arming process has not changed the armed-state of HA. The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA" and "Arm HA" are complements. There may be more suitable pairs of icons though. Signed-off-by: Dominik Rusovac --- changes since v2: * inline setting isDisarmed flag * use 'tbar' * switch positions of buttons * hook into 'hastatuschange' to provide feedback via spinning icon while armed-state of HA changes: - add 'isDisarmedPendingState' to controller - on successful (dis)arm request, store expected 'isDisarmed'-value in 'isDisarmedPendingState' - match 'isDisarmedPendingState' on 'isDisarmed' in 'hastatuschange' and clear 'isDisarmedPendingState' www/manager6/ha/Status.js | 113 ++++++++++++++++++++++++++++++++++ www/manager6/ha/StatusView.js | 8 +++ 2 files changed, 121 insertions(+) diff --git a/www/manager6/ha/Status.js b/www/manager6/ha/Status.js index b0b0feb9..42b498ef 100644 --- a/www/manager6/ha/Status.js +++ b/www/manager6/ha/Status.js @@ -8,6 +8,102 @@ Ext.define('PVE.ha.Status', { align: 'stretch', }, + viewModel: { + data: { + haDisarmed: false, + }, + }, + + controller: { + xclass: 'Ext.app.ViewController', + + isDisarmedPendingState: null, + + handleDisarmButton: function (menuItem) { + let me = this; + let view = me.getView(); + + Ext.Msg.confirm( + gettext('Confirm'), + Ext.String.format( + gettext("Are you sure you want to disarm HA with resource mode '{0}'?"), + menuItem.text, + ), + function (btn) { + if (btn !== 'yes') { + return; + } + Proxmox.Utils.API2Request({ + url: '/cluster/ha/status/disarm-ha', + params: { 'resource-mode': menuItem.mode }, + method: 'POST', + success: function () { + me.isDisarmedPendingState = true; + view.mask(gettext('Disarming HA...')); + }, + failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + }); + }, + ); + }, + + handleArmButton: function () { + let me = this; + let view = me.getView(); + + Ext.Msg.confirm( + gettext('Confirm'), + gettext('Are you sure you want to arm HA?'), + function (btn) { + if (btn !== 'yes') { + return; + } + Proxmox.Utils.API2Request({ + url: '/cluster/ha/status/arm-ha', + method: 'POST', + success: function () { + me.isDisarmedPendingState = false; + view.mask(gettext('Arming HA...')); + }, + failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + }); + }, + ); + }, + }, + + tbar: [ + { + text: gettext('Arm HA'), + iconCls: 'fa fa-link', + bind: { + disabled: '{!haDisarmed}', + }, + handler: 'handleArmButton', + }, + { + text: gettext('Disarm HA'), + iconCls: 'fa fa-unlink', + bind: { + disabled: '{haDisarmed}', + }, + menu: [ + { + text: gettext('Freeze'), + iconCls: 'fa fa-snowflake-o', + mode: 'freeze', + handler: 'handleDisarmButton', + }, + { + text: gettext('Ignore'), + iconCls: 'fa fa-eye-slash', + mode: 'ignore', + handler: 'handleDisarmButton', + }, + ], + }, + ], + initComponent: function () { var me = this; @@ -30,6 +126,23 @@ Ext.define('PVE.ha.Status', { border: 0, collapsible: true, padding: '0 0 20 0', + listeners: { + hastatuschange: function (isDisarmed) { + let vm = me.getViewModel(); + let controller = me.getController(); + + vm.set('haDisarmed', isDisarmed); + + if (controller.isDisarmedPendingState === null) { + return; + } + + if (isDisarmed === controller.isDisarmedPendingState) { + me.unmask(); + controller.isDisarmedPendingState = null; + } + }, + }, }, { xtype: 'pveHAResourcesView', diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js index bc2da71f..4cbe85a1 100644 --- a/www/manager6/ha/StatusView.js +++ b/www/manager6/ha/StatusView.js @@ -42,6 +42,13 @@ Ext.define( }, }); + me.rstore.on('load', function () { + let fencing = store.findRecord('type', 'fencing'); + let disarmed = fencing && fencing.get('armed-state') === 'disarmed'; + + me.fireEvent('hastatuschange', disarmed); + }); + Ext.apply(me, { store: store, stateful: false, @@ -105,6 +112,7 @@ Ext.define( return PVE.data.ResourceStore.guestName(vmid); }, }, + 'armed-state', ], idProperty: 'id', }); -- 2.47.3