all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-qemu] d/control: drop redundant library deps covered by shlibs:Depends
@ 2026-04-14  3:05 Kefu Chai
  2026-04-14 14:04 ` applied: " Fiona Ebner
  0 siblings, 1 reply; 2+ messages in thread
From: Kefu Chai @ 2026-04-14  3:05 UTC (permalink / raw)
  To: pve-devel

Remove manually maintained library dependencies that are already
auto-detected by dh_shlibdeps via ${shlibs:Depends}:

* libiscsi4 (>= 1.12.0) | libiscsi7
* libjpeg62-turbo
* libspice-server1 (>= 0.14.0~)
* libusb-1.0-0 (>= 1.0.17-1)
* libusbredirparser1 (>= 0.6-2)
* libuuid1

The auto-detected versions are more accurate (derived from symbol
versioning) and don't need manual updates during library transitions.
For example, libusbredirparser1 (>= 0.6-2) was stale -- the library
was renamed to libusbredirparser1t64 during the t64 transition, and
shlibs:Depends correctly generates libusbredirparser1t64 (>= 0.8.0).

Non-library runtime deps (ceph-common, fuse3, iproute2) are kept
since dh_shlibdeps only detects shared libraries.

Verified by building the package and comparing the generated
debian/pve-qemu-kvm.substvars against the removed entries. All six
libraries are present in the shlibs:Depends output with tighter
version constraints:

  hardcoded                          shlibs:Depends
  libiscsi4 (>= 1.12.0) | libiscsi7 libiscsi7 (>= 1.18.0)
  libjpeg62-turbo                    libjpeg62-turbo (>= 1.3.1)
  libspice-server1 (>= 0.14.0~)     libspice-server1 (>= 0.14.2)
  libusb-1.0-0 (>= 1.0.17-1)        libusb-1.0-0 (>= 2:1.0.23~)
  libusbredirparser1 (>= 0.6-2)     libusbredirparser1t64 (>= 0.8.0)
  libuuid1                           libuuid1 (>= 2.16)

Suggested-by: Fabian Gruenbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 debian/control | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/debian/control b/debian/control
index 81cc026..ff1d5af 100644
--- a/debian/control
+++ b/debian/control
@@ -48,12 +48,6 @@ Architecture: any
 Depends: ceph-common (>= 0.48),
          fuse3,
          iproute2,
-         libiscsi4 (>= 1.12.0) | libiscsi7,
-         libjpeg62-turbo,
-         libspice-server1 (>= 0.14.0~),
-         libusb-1.0-0 (>= 1.0.17-1),
-         libusbredirparser1 (>= 0.6-2),
-         libuuid1,
          ${misc:Depends},
          ${shlibs:Depends},
 Recommends: numactl,
-- 
2.47.3





^ permalink raw reply	[flat|nested] 2+ messages in thread

* applied: [PATCH pve-qemu] d/control: drop redundant library deps covered by shlibs:Depends
  2026-04-14  3:05 [PATCH pve-qemu] d/control: drop redundant library deps covered by shlibs:Depends Kefu Chai
@ 2026-04-14 14:04 ` Fiona Ebner
  0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2026-04-14 14:04 UTC (permalink / raw)
  To: pve-devel, Kefu Chai

On Tue, 14 Apr 2026 11:05:27 +0800, Kefu Chai wrote:
> Remove manually maintained library dependencies that are already
> auto-detected by dh_shlibdeps via ${shlibs:Depends}:
> 
> * libiscsi4 (>= 1.12.0) | libiscsi7
> * libjpeg62-turbo
> * libspice-server1 (>= 0.14.0~)
> * libusb-1.0-0 (>= 1.0.17-1)
> * libusbredirparser1 (>= 0.6-2)
> * libuuid1
> 
> [...]

Applied, thanks! Added a few spaces to improve the alignment for the
comparision in the commit message and put the 'ü' back in Fabian's
name.

[1/1] d/control: drop redundant library deps covered by shlibs:Depends
      commit: 0ffa56b39ac1a340d087f3cca05f25706bf4bfc4




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-14 14:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-14  3:05 [PATCH pve-qemu] d/control: drop redundant library deps covered by shlibs:Depends Kefu Chai
2026-04-14 14:04 ` applied: " Fiona Ebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal