all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-qemu] d/control: drop redundant library deps covered by shlibs:Depends
Date: Tue, 14 Apr 2026 11:05:27 +0800	[thread overview]
Message-ID: <20260414030527.3680950-1-k.chai@proxmox.com> (raw)

Remove manually maintained library dependencies that are already
auto-detected by dh_shlibdeps via ${shlibs:Depends}:

* libiscsi4 (>= 1.12.0) | libiscsi7
* libjpeg62-turbo
* libspice-server1 (>= 0.14.0~)
* libusb-1.0-0 (>= 1.0.17-1)
* libusbredirparser1 (>= 0.6-2)
* libuuid1

The auto-detected versions are more accurate (derived from symbol
versioning) and don't need manual updates during library transitions.
For example, libusbredirparser1 (>= 0.6-2) was stale -- the library
was renamed to libusbredirparser1t64 during the t64 transition, and
shlibs:Depends correctly generates libusbredirparser1t64 (>= 0.8.0).

Non-library runtime deps (ceph-common, fuse3, iproute2) are kept
since dh_shlibdeps only detects shared libraries.

Verified by building the package and comparing the generated
debian/pve-qemu-kvm.substvars against the removed entries. All six
libraries are present in the shlibs:Depends output with tighter
version constraints:

  hardcoded                          shlibs:Depends
  libiscsi4 (>= 1.12.0) | libiscsi7 libiscsi7 (>= 1.18.0)
  libjpeg62-turbo                    libjpeg62-turbo (>= 1.3.1)
  libspice-server1 (>= 0.14.0~)     libspice-server1 (>= 0.14.2)
  libusb-1.0-0 (>= 1.0.17-1)        libusb-1.0-0 (>= 2:1.0.23~)
  libusbredirparser1 (>= 0.6-2)     libusbredirparser1t64 (>= 0.8.0)
  libuuid1                           libuuid1 (>= 2.16)

Suggested-by: Fabian Gruenbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 debian/control | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/debian/control b/debian/control
index 81cc026..ff1d5af 100644
--- a/debian/control
+++ b/debian/control
@@ -48,12 +48,6 @@ Architecture: any
 Depends: ceph-common (>= 0.48),
          fuse3,
          iproute2,
-         libiscsi4 (>= 1.12.0) | libiscsi7,
-         libjpeg62-turbo,
-         libspice-server1 (>= 0.14.0~),
-         libusb-1.0-0 (>= 1.0.17-1),
-         libusbredirparser1 (>= 0.6-2),
-         libuuid1,
          ${misc:Depends},
          ${shlibs:Depends},
 Recommends: numactl,
-- 
2.47.3





             reply	other threads:[~2026-04-14  3:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  3:05 Kefu Chai [this message]
2026-04-14 14:04 ` applied: " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260414030527.3680950-1-k.chai@proxmox.com \
    --to=k.chai@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal