applied-series: [PATCH proxmox-acme 0/3] acme: fix missing/diverging shim helpers, tighten missing-function check

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

thanks!

On September 25, 2026 2:47 pm, Mathias Bartmann wrote:
> dns_oci.sh (Oracle Cloud DNS) cannot complete a DNS-01 challenge,
> see bug #7851 for the full analysis. Patch 1 fixes the two shim helpers
> behind it and adds a test running them through the shim.
> 
> While looking at why this was not caught at build time, it turned out
> that check-missing-functions misses calls at the end of a command
> substitution or pipe, and drops any line that also has an assignment.
> With that fixed (patch 3) it finds a third missing helper, _url_replace
> used by dns_yc.sh, added in patch 2 so the series passes at every
> commit.
> 
> A minimal fix within the existing grep pipeline is possible, but it
> still drops any line that also calls a known helper, so it would not
> catch _url_replace, and it needs ten more false-positive entries for
> variables after export, unset and read. The rewrite checks each called
> name individually, so the expected list shrinks to the one real
> upstream issue (dns_aws.sh: _error). Happy to send the minimal variant
> instead if you prefer.
> 
> Patch 1 was verified end to end on PVE 9.2 with an OCI-hosted zone:
> certificate ordered and installed on pveproxy. Patch 2 is a verbatim
> copy of the upstream helper, but I could not test it against Yandex
> Cloud.
> 
> Mathias Bartmann (3):
>   fix #7851: acme: add missing _mktemp and restore _dbase64 default
>   acme: add missing _url_replace function
>   tests: rewrite check-missing-functions to catch calls in substitutions
> 
>  src/proxmox-acme                    | 15 +++++++-
>  src/test/Makefile                   |  2 +-
>  src/test/check-missing-functions    | 59 ++++++++++++++++++++++++-----
>  src/test/missing-functions.expected |  8 +---
>  src/test/test-shim-helpers          | 37 ++++++++++++++++++
>  5 files changed, 102 insertions(+), 19 deletions(-)
>  create mode 100755 src/test/test-shim-helpers
> 
> -- 
> 2.55.0
> 
> 
> 
> 
>