From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5747F1FF0DF for ; Thu, 05 Nov 2026 14:54:29 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E3DDE21553; Thu, 05 Nov 2026 14:54:25 +0100 (CET) Date: Thu, 05 Nov 2026 14:54:18 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: applied-series: [PATCH proxmox-acme 0/3] acme: fix missing/diverging shim helpers, tighten missing-function check To: Mathias Bartmann , pve-devel@lists.proxmox.com References: <20260925124737.42866-1-mathias.bartmann@gmail.com> In-Reply-To: <20260925124737.42866-1-mathias.bartmann@gmail.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1793886673.34ngzwnpaw.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793886861063 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.585 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JCIYAJ2CIGYQNPFOMBMNTAA5NKY5ILG5 X-Message-ID-Hash: JCIYAJ2CIGYQNPFOMBMNTAA5NKY5ILG5 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: thanks! On September 25, 2026 2:47 pm, Mathias Bartmann wrote: > dns_oci.sh (Oracle Cloud DNS) cannot complete a DNS-01 challenge, > see bug #7851 for the full analysis. Patch 1 fixes the two shim helpers > behind it and adds a test running them through the shim. >=20 > While looking at why this was not caught at build time, it turned out > that check-missing-functions misses calls at the end of a command > substitution or pipe, and drops any line that also has an assignment. > With that fixed (patch 3) it finds a third missing helper, _url_replace > used by dns_yc.sh, added in patch 2 so the series passes at every > commit. >=20 > A minimal fix within the existing grep pipeline is possible, but it > still drops any line that also calls a known helper, so it would not > catch _url_replace, and it needs ten more false-positive entries for > variables after export, unset and read. The rewrite checks each called > name individually, so the expected list shrinks to the one real > upstream issue (dns_aws.sh: _error). Happy to send the minimal variant > instead if you prefer. >=20 > Patch 1 was verified end to end on PVE 9.2 with an OCI-hosted zone: > certificate ordered and installed on pveproxy. Patch 2 is a verbatim > copy of the upstream helper, but I could not test it against Yandex > Cloud. >=20 > Mathias Bartmann (3): > fix #7851: acme: add missing _mktemp and restore _dbase64 default > acme: add missing _url_replace function > tests: rewrite check-missing-functions to catch calls in substitutions >=20 > src/proxmox-acme | 15 +++++++- > src/test/Makefile | 2 +- > src/test/check-missing-functions | 59 ++++++++++++++++++++++++----- > src/test/missing-functions.expected | 8 +--- > src/test/test-shim-helpers | 37 ++++++++++++++++++ > 5 files changed, 102 insertions(+), 19 deletions(-) > create mode 100755 src/test/test-shim-helpers >=20 > --=20 > 2.55.0 >=20 >=20 >=20 >=20 >=20