From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: [PATCH qemu-server 7/7] volume chain: blockdev delete: pass volume ID instead of drive and mark private
Date: Fri, 16 Oct 2026 01:37:44 +0200 [thread overview]
Message-ID: <179210744307.3827773.1261244882993186015.b4-ty@b4> (raw)
In-Reply-To: <20260925122646.139215-8-f.ebner@proxmox.com>
On Fri, 25 Sep 2026 14:26:31 +0200, Fiona Ebner wrote:
> The only part of the drive that's used by blockdev_delete() is the
> volume ID.
>
> Remove the local volid variables in blockdev_{commit,stream}() which
> are in-scope for the whole function but never used.
>
> The blockdev_delete() function is not used outside of the VolumeChain
> module and it has a quite specific signature tailored towards its two
> existing callers.
>
> [...]
Applied, thanks!
[7/7] volume chain: blockdev delete: pass volume ID instead of drive and mark private
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=7d84c796faaa21a1d21ca12a3fe28c1b29c008d7
next prev parent reply other threads:[~2026-10-15 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 12:26 [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 1/7] volume snapshot (delete): avoid using deprecated check_running() helper Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 2/7] volume snapshot delete: move getting attached device ID to caller Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 3/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 4/7] snapshot: add module for snapshot-related functionality Fiona Ebner
2026-10-15 23:37 ` applied: " Thomas Lamprecht
2026-09-25 12:26 ` [PATCH qemu-server 5/7] snapshot: use v5.36 and subroutine signatures Fiona Ebner
2026-10-15 23:37 ` applied: " Thomas Lamprecht
2026-09-25 12:26 ` [PATCH qemu-server 6/7] volume chain: blockdev delete: remove superfluous parse_volume_id() call Fiona Ebner
2026-10-15 23:37 ` applied: " Thomas Lamprecht
2026-09-25 12:26 ` [PATCH qemu-server 7/7] volume chain: blockdev delete: pass volume ID instead of drive and mark private Fiona Ebner
2026-10-15 23:37 ` Thomas Lamprecht [this message]
2026-10-08 8:47 ` [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-10-15 23:37 ` applied: (subset) " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179210744307.3827773.1261244882993186015.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.