From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: applied: (subset) [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling
Date: Fri, 16 Oct 2026 01:37:45 +0200 [thread overview]
Message-ID: <179210744271.3827773.904461787424534644.b4-ty@b4> (raw)
In-Reply-To: <20260925122646.139215-1-f.ebner@proxmox.com>
On Fri, 25 Sep 2026 14:26:24 +0200, Fiona Ebner wrote:
> When removing a volume chain snapshot, the blockdev properties are
> re-generated in blockdev_{commit,replace,stream}() to operate upon.
> This must happen with the current drive information, not the one from
> the time the snapshot was taken.
>
> A similar bug was present before volume chain snapshots existed, and
> fixed by commit c6058683 ("fix #2258: select correct device when
> removing drive snapshot via QEMU"). This is where the handling for
> $attached_deviceid comes from. With snapshot-as-volume-chain, this
> needs to be extended to the full drive information, not just the
> device ID.
>
> [...]
Applied, thanks!
[1/7] volume snapshot (delete): avoid using deprecated check_running() helper
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=5170164706fb1460968a2232babbdd910685cbeb
[2/7] volume snapshot delete: move getting attached device ID to caller
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=7552590ed754e587aa67361d85b60717689dd678
[3/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=30b0e83b2bbba8be6764b0e9f4c61de29574012b
prev parent reply other threads:[~2026-10-15 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 12:26 [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 1/7] volume snapshot (delete): avoid using deprecated check_running() helper Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 2/7] volume snapshot delete: move getting attached device ID to caller Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 3/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 4/7] snapshot: add module for snapshot-related functionality Fiona Ebner
2026-10-15 23:37 ` applied: " Thomas Lamprecht
2026-09-25 12:26 ` [PATCH qemu-server 5/7] snapshot: use v5.36 and subroutine signatures Fiona Ebner
2026-10-15 23:37 ` applied: " Thomas Lamprecht
2026-09-25 12:26 ` [PATCH qemu-server 6/7] volume chain: blockdev delete: remove superfluous parse_volume_id() call Fiona Ebner
2026-10-15 23:37 ` applied: " Thomas Lamprecht
2026-09-25 12:26 ` [PATCH qemu-server 7/7] volume chain: blockdev delete: pass volume ID instead of drive and mark private Fiona Ebner
2026-10-15 23:37 ` applied: " Thomas Lamprecht
2026-10-08 8:47 ` [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-10-15 23:37 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179210744271.3827773.904461787424534644.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.