From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 2/7] volume snapshot delete: move getting attached device ID to caller
Date: Fri, 25 Sep 2026 14:26:26 +0200 [thread overview]
Message-ID: <20260925122646.139215-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260925122646.139215-1-f.ebner@proxmox.com>
In preparation to move the volume snapshot helpers to a separate
module that will not depend on QemuConfig.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/QemuConfig.pm | 18 +++++++++++++++++-
src/PVE/QemuServer.pm | 15 +--------------
2 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
index 2ef6c075..3dd69ce8 100644
--- a/src/PVE/QemuConfig.pm
+++ b/src/PVE/QemuConfig.pm
@@ -438,7 +438,23 @@ sub __snapshot_delete_vol_snapshot {
my $storecfg = PVE::Storage::config();
my $volid = $drive->{file};
- PVE::QemuServer::qemu_volume_snapshot_delete($vmid, $storecfg, $drive, $snapname);
+ my $running = PVE::QemuServer::Helpers::vm_running_locally($vmid);
+ my $attached_deviceid;
+
+ if ($running) {
+ my $conf = $class->load_config($vmid);
+ $class->foreach_volume(
+ $conf,
+ sub {
+ my ($ds, $drive) = @_;
+ $attached_deviceid = "drive-$ds" if $drive->{file} eq $volid;
+ },
+ );
+ }
+
+ PVE::QemuServer::qemu_volume_snapshot_delete(
+ $vmid, $storecfg, $drive, $snapname, $attached_deviceid, $running,
+ );
push @$unused, $volid;
}
diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 036dc4c1..e76a6ec4 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -4366,22 +4366,9 @@ sub qemu_volume_snapshot {
}
sub qemu_volume_snapshot_delete {
- my ($vmid, $storecfg, $drive, $snap) = @_;
+ my ($vmid, $storecfg, $drive, $snap, $attached_deviceid, $running) = @_;
my $volid = $drive->{file};
- my $running = PVE::QemuServer::Helpers::vm_running_locally($vmid);
- my $attached_deviceid;
-
- if ($running) {
- my $conf = PVE::QemuConfig->load_config($vmid);
- PVE::QemuConfig->foreach_volume(
- $conf,
- sub {
- my ($ds, $drive) = @_;
- $attached_deviceid = "drive-$ds" if $drive->{file} eq $volid;
- },
- );
- }
my $do_snapshots_type = do_snapshots_type($storecfg, $drive, $attached_deviceid, $running);
--
2.47.3
next prev parent reply other threads:[~2026-09-25 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 12:26 [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 1/7] volume snapshot (delete): avoid using deprecated check_running() helper Fiona Ebner
2026-09-25 12:26 ` Fiona Ebner [this message]
2026-09-25 12:26 ` [PATCH qemu-server 3/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 4/7] snapshot: add module for snapshot-related functionality Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 5/7] snapshot: use v5.36 and subroutine signatures Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 6/7] volume chain: blockdev delete: remove superfluous parse_volume_id() call Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 7/7] volume chain: blockdev delete: pass volume ID instead of drive and mark private Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925122646.139215-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.