* [PATCH yew-widget-toolkit] widget: map: fix info positioning on firefox
@ 2026-05-26 13:33 Dominik Csapak
2026-05-26 23:11 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2026-05-26 13:33 UTC (permalink / raw)
To: pdm-devel
On at least some firefox versions (tested with 140 ESR), drawing an SVG
circle with radius 0 does not position it correctly (it will in the SVG
origin instead of the specified coordinates). This lead to the info
popup on the map to be always relative to the top left of the whole map,
instead of above the selected point.
To fix this, make the circle have a radius of 1 and make it transparent.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/widget/charts/map/mod.rs | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/widget/charts/map/mod.rs b/src/widget/charts/map/mod.rs
index 225a851..d6d142a 100644
--- a/src/widget/charts/map/mod.rs
+++ b/src/widget/charts/map/mod.rs
@@ -446,7 +446,8 @@ impl<T: MapPointData + 'static> yew::Component for MapComp<T> {
Circle::new()
.cx(center.x)
.cy(center.y)
- .r(0)
+ .r(1)
+ .fill("transparent")
.into_html_with_ref(self.info_anchor_ref.clone()),
);
info = Some(self.create_info(&args));
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* applied: [PATCH yew-widget-toolkit] widget: map: fix info positioning on firefox
2026-05-26 13:33 [PATCH yew-widget-toolkit] widget: map: fix info positioning on firefox Dominik Csapak
@ 2026-05-26 23:11 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-05-26 23:11 UTC (permalink / raw)
To: pdm-devel, Dominik Csapak
On Tue, 26 May 2026 15:33:14 +0200, Dominik Csapak wrote:
> On at least some firefox versions (tested with 140 ESR), drawing an SVG
> circle with radius 0 does not position it correctly (it will in the SVG
> origin instead of the specified coordinates). This lead to the info
> popup on the map to be always relative to the top left of the whole map,
> instead of above the selected point.
>
> To fix this, make the circle have a radius of 1 and make it transparent.
>
> [...]
Applied, thanks!
[1/1] widget: map: fix info positioning on firefox
commit: 3ab4b41fa64c56c629c388d1324b34b94fc86e27
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-26 23:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-26 13:33 [PATCH yew-widget-toolkit] widget: map: fix info positioning on firefox Dominik Csapak
2026-05-26 23:11 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.